fix: resolve CodeRabbit recommendations for custom-base-url

- Fix base URL duplication bug by checking if /openai/v1 already exists
- Add URL validation for CLI and config setBaseUrl methods
- Properly handle URL format errors with clear error messages
- Maintain correct precedence: ENV > config > default

Author: hongkongkiwi

src/core/agent.ts

@@ -618,9 +618,17 @@ function debugLog(message: string, data?: any) {
  */
 function resolveEffectiveBaseUrl(configManager: ConfigManager): string {
   const env = process.env.GROQ_BASE_URL;
-  if (env) return env.replace(/\/+$/, '') + '/openai/v1';
+  if (env) {
+    // Don't append /openai/v1 if it's already in the URL
+    const normalized = env.replace(/\/+$/, '');
+    return normalized.includes('/openai/v1') ? normalized : normalized + '/openai/v1';
+  }
   const cfg = configManager.getBaseUrl();
-  if (cfg) return cfg.replace(/\/+$/, '') + '/openai/v1';
+  if (cfg) {
+    // Don't append /openai/v1 if it's already in the URL
+    const normalized = cfg.replace(/\/+$/, '');
+    return normalized.includes('/openai/v1') ? normalized : normalized + '/openai/v1';
+  }
   return 'https://api.groq.com/openai/v1';
 }
 

src/core/cli.ts

@@ -38,6 +38,13 @@ async function startChat(
   try {
     // Set base URL if provided via CLI
     if (baseUrl) {
+      // Validate URL format
+      try {
+        new URL(baseUrl);
+      } catch (error) {
+        console.log(chalk.red(`Invalid base URL format: ${baseUrl}`));
+        process.exit(1);
+      }
       process.env.GROQ_BASE_URL = baseUrl;
     }
 

src/utils/local-settings.ts

@@ -144,10 +144,17 @@ export class ConfigManager {
    * This URL will be used when creating the Groq client if GROQ_BASE_URL env var is not set.
    * 
    * @param baseUrl - The custom API base URL to save (e.g., "https://custom-api.example.com")
-   * @throws Error if unable to save the configuration
+   * @throws Error if unable to save the configuration or URL is invalid
    */
   public setBaseUrl(baseUrl: string): void {
     try {
+      // Validate URL format
+      try {
+        new URL(baseUrl);
+      } catch (error) {
+        throw new Error(`Invalid URL format: ${baseUrl}`);
+      }
+      
       this.ensureConfigDir();
 
       let config: Config = {};