feat(ui-tars): refact GUIAgentError

Author: ZhaoHeh

apps/ui-tars/src/main/services/runAgent.ts

@@ -171,7 +171,11 @@ export const runAgent = async (
       setState({
         ...getState(),
         status: StatusEnum.ERROR,
-        errorMsg: JSON.stringify(error),
+        errorMsg: JSON.stringify({
+          status: error.status,
+          message: error.message,
+          stack: error.stack,
+        }),
       });
     },
     retry: {

apps/ui-tars/src/renderer/src/components/RunMessages/Messages.tsx

@@ -31,7 +31,7 @@ export const ErrorMessage = ({ text }: { text: string }) => {
   let parsedError: GUIAgentError | null = null;
   try {
     const parsed = JSON.parse(text);
-    if (parsed && typeof parsed === 'object' && 'code' in parsed) {
+    if (parsed && typeof parsed === 'object' && 'status' in parsed) {
       parsedError = parsed as GUIAgentError;
     }
   } catch {
@@ -44,7 +44,7 @@ export const ErrorMessage = ({ text }: { text: string }) => {
         <AlertCircle className="w-5 h-5 text-red-500 shrink-0" />
         <span className="font-medium text-red-500">
           {parsedError
-            ? ErrorStatusEnum[parsedError.code] || 'UNKNOWN_ERROR'
+            ? ErrorStatusEnum[parsedError.status] || 'UNKNOWN_ERROR'
             : 'Error'}
         </span>
       </div>
@@ -53,16 +53,10 @@ export const ErrorMessage = ({ text }: { text: string }) => {
           <div className="text-sm text-red-500/90 font-medium">
             {parsedError.message}
           </div>
-          {parsedError.stack ? (
+          {parsedError.stack && (
             <div className="text-xs text-red-500/70 font-mono mt-2">
               {parsedError.stack}
             </div>
-          ) : (
-            parsedError.detail && (
-              <div className="text-xs text-red-500/70 font-mono mt-2">
-                {parsedError.detail}
-              </div>
-            )
           )}
         </div>
       ) : (

packages/ui-tars/sdk/src/GUIAgent.ts

@@ -32,6 +32,7 @@ import {
   SYSTEM_PROMPT,
   SYSTEM_PROMPT_TEMPLATE,
 } from './constants';
+import { InternalServerError } from 'openai';
 
 export class GUIAgent<T extends Operator> extends BaseGUIAgent<
   GUIAgentConfig<T>
@@ -489,66 +490,71 @@ export class GUIAgent<T extends Operator> extends BaseGUIAgent<
     error: unknown,
     type: ErrorStatusEnum | null = null,
   ): GUIAgentError {
-    if (
-      error instanceof Error &&
-      'status' in error &&
-      'error' in error &&
-      error.status === 500 &&
-      typeof error.error === 'string' &&
-      error.error.includes('unhandled errors in a TaskGroup')
-    ) {
-      return new GUIAgentError(
+    this.logger.error('[GUIAgent] guiAgentErrorParser:', error);
+
+    let parseError = null;
+
+    if (error instanceof InternalServerError) {
+      this.logger.error(
+        '[GUIAgent] guiAgentErrorParser instanceof InternalServerError.',
+      );
+      parseError = new GUIAgentError(
         ErrorStatusEnum.MODEL_SERVICE_ERROR,
         error.message,
         error.stack,
-        JSON.stringify(error),
       );
     }
 
-    if (type === ErrorStatusEnum.REACH_MAXLOOP_ERROR) {
-      return new GUIAgentError(
+    if (!parseError && type === ErrorStatusEnum.REACH_MAXLOOP_ERROR) {
+      parseError = new GUIAgentError(
         ErrorStatusEnum.REACH_MAXLOOP_ERROR,
         'Has reached max loop count',
       );
     }
 
-    if (type === ErrorStatusEnum.SCREENSHOT_RETRY_ERROR) {
-      return new GUIAgentError(
+    if (!parseError && type === ErrorStatusEnum.SCREENSHOT_RETRY_ERROR) {
+      parseError = new GUIAgentError(
         ErrorStatusEnum.SCREENSHOT_RETRY_ERROR,
         'Too many screenshot failures',
       );
     }
 
-    if (type === ErrorStatusEnum.INVOKE_RETRY_ERROR) {
-      return new GUIAgentError(
+    if (!parseError && type === ErrorStatusEnum.INVOKE_RETRY_ERROR) {
+      parseError = new GUIAgentError(
         ErrorStatusEnum.INVOKE_RETRY_ERROR,
         'Too many model invoke failures',
         'null',
-        JSON.stringify(error),
       );
     }
 
-    if (type === ErrorStatusEnum.EXECUTE_RETRY_ERROR) {
-      return new GUIAgentError(
+    if (!parseError && type === ErrorStatusEnum.EXECUTE_RETRY_ERROR) {
+      parseError = new GUIAgentError(
         ErrorStatusEnum.EXECUTE_RETRY_ERROR,
         'Too many action execute failures',
         'null',
-        JSON.stringify(error),
       );
     }
 
-    if (type === ErrorStatusEnum.ENVIRONMENT_ERROR) {
-      return new GUIAgentError(
+    if (!parseError && type === ErrorStatusEnum.ENVIRONMENT_ERROR) {
+      parseError = new GUIAgentError(
         ErrorStatusEnum.ENVIRONMENT_ERROR,
         'The environment error occurred when parsing the action',
       );
     }
 
-    return new GUIAgentError(
-      ErrorStatusEnum.UNKNOWN_ERROR,
-      error instanceof Error ? error.message : 'Unknown error occurred',
-      error instanceof Error ? error.stack || 'null' : 'null',
-      JSON.stringify(error),
-    );
+    if (!parseError) {
+      parseError = new GUIAgentError(
+        ErrorStatusEnum.UNKNOWN_ERROR,
+        error instanceof Error ? error.message : 'Unknown error occurred',
+        error instanceof Error ? error.stack || 'null' : 'null',
+      );
+    }
+
+    if (!parseError.stack) {
+      // Avoid guiAgentErrorParser it self in stack trace
+      Error.captureStackTrace(parseError, this.guiAgentErrorParser);
+    }
+
+    return parseError;
   }
 }

packages/ui-tars/shared/src/types/agent.ts

@@ -25,22 +25,15 @@ export enum ErrorStatusEnum {
 }
 
 export class GUIAgentError extends Error {
-  code: ErrorStatusEnum;
+  status: ErrorStatusEnum;
   message: string;
   stack?: string;
-  detail?: string;
 
-  constructor(
-    code: ErrorStatusEnum,
-    message: string,
-    stack?: string,
-    detail?: string,
-  ) {
-    super(code.toString());
-    this.code = code;
+  constructor(status: ErrorStatusEnum, message: string, stack?: string) {
+    super(message);
+    this.status = status;
     this.message = message;
     this.stack = stack;
-    this.detail = detail;
   }
 }