Skip to content

Commit 92a1cab

Browse files
committed
feat: drop sdwebimage, implement svg decoder
1 parent 6f87ff1 commit 92a1cab

File tree

15 files changed

+579
-1297
lines changed

15 files changed

+579
-1297
lines changed

.changeset/sour-cases-appear.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'react-native-bottom-tabs': minor
3+
---
4+
5+
feat: drop SDWebImage, resolve bunch of build issues

CONTRIBUTING.md

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,7 @@ To run the React Native example app on Android:
3939
yarn workspace react-native-bottom-tabs-example android
4040
```
4141

42-
To run the React Native example app on iOS:
43-
44-
Make sure to install [`cocoapods-swift-modular-headers`](https://github.com/callstack/cocoapods-swift-modular-headers) gem, otherwise `pod install` will fail.
45-
46-
```sh
47-
gem install cocoapods-swift-modular-headers
48-
```
49-
50-
Next you can install cocoapods.
42+
To run the React Native example app on iOS, you need to install cocoapods.
5143

5244
```sh
5345
cd apps/example/ios

apps/example/ios/Podfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
plugin 'cocoapods-swift-modular-headers'
1+
ENV['RCT_NEW_ARCH_ENABLED'] = '1'
2+
ENV['RCT_USE_RN_DEP'] = '1'
23

34
ws_dir = Pathname.new(__dir__)
45
ws_dir = ws_dir.parent until
@@ -8,6 +9,4 @@ require "#{ws_dir}/node_modules/react-native-test-app/test_app.rb"
89

910
workspace 'ReactNativeBottomTabsExample.xcworkspace'
1011

11-
apply_modular_headers_for_swift_dependencies()
12-
1312
use_test_app! :hermes_enabled => true, :fabric_enabled => true

0 commit comments

Comments
 (0)