Fix: Prevent unaligned access in ping function

Previously we were doing some UB stuff -- using reinterpret cast on a
byte buffer.  Instead we use std::memcpy to copy a quint32 to the
buffer -- this is portable and not UB.

Author: cculianu

WebSocket.cpp

@@ -43,6 +43,7 @@
 
 #include <algorithm>
 #include <cassert>
+#include <cstddef>
 #include <chrono>
 #include <cstring>
 #include <limits>
@@ -1023,7 +1024,11 @@ namespace WebSocket
                     return;
                 }
                 QByteArray data(sizeof(quint32), Qt::Uninitialized);
-                *reinterpret_cast<quint32 *>(data.data()) = QRandomGenerator::global()->generate();
+                {
+                    const quint32 randVal = QRandomGenerator::global()->generate();
+                    // prevent unaligned access
+                    std::memcpy(data.data(), reinterpret_cast<const std::byte *>(&randVal), sizeof(randVal));
+                }
                 sendPing(data);
                 if (getTime() - lastPongRecvd >= pingTimer->interval()*2) {
                     qDebug() << "Ping timeout for" << QString::asprintf("%s:%hu", peerAddress().toString().toUtf8().constData(), peerPort());