Lint-roll the JS sources

Author: acrellin

static/js/actions.js

@@ -439,20 +439,18 @@ export function computeFeatures(form) {
 
 
 export function uploadFeatureset(form, currentProject) {
-
-  function fileReaderPromise(form, fileName, binary = false){
+  function fileReaderPromise(formFields, fileName, binary = false) {
     return new Promise(resolve => {
-      var filereader = new FileReader();
+      const filereader = new FileReader();
       if (binary) {
-        filereader.readAsDataURL(form[fileName][0]);
+        filereader.readAsDataURL(formFields[fileName][0]);
       } else {
-        filereader.readAsText(form[fileName][0]);
+        filereader.readAsText(formFields[fileName][0]);
       }
       filereader.onloadend = () => resolve({ body: filereader.result,
-                                             name: form[fileName][0].name });
+                                             name: formFields[fileName][0].name });
     });
   }
-
   form['projectID'] = currentProject.id;
 
   return dispatch =>
@@ -470,7 +468,7 @@ export function uploadFeatureset(form, currentProject) {
             headers: new Headers({
               'Content-Type': 'application/json'
             })
-          })
+          });
         })
         .then(response => response.json())
         .then((json) => {

static/js/components/Features.jsx

@@ -50,6 +50,7 @@ let FeaturesTab = (props) => {
 FeaturesTab.propTypes = {
   featurePlotURL: PropTypes.string.isRequired,
   computeFeatures: PropTypes.func.isRequired,
+  uploadFeatures: PropTypes.func.isRequired,
   selectedProject: PropTypes.object
 };
 FeaturesTab.defaultProps = {
@@ -60,7 +61,8 @@ const ftMapDispatchToProps = (dispatch, ownProps) => (
   {
     computeFeatures: form => dispatch(Action.computeFeatures(form)),
     uploadFeatures: form => dispatch(
-      Action.uploadFeatureset(form, ownProps.selectedProject))
+      Action.uploadFeatureset(form, ownProps.selectedProject)
+    )
   }
 );
 

static/js/components/FeaturesetsTable.jsx

@@ -1,4 +1,5 @@
 import React from 'react';
+import PropTypes from 'prop-types';
 import { connect } from 'react-redux';
 
 import { reformatDatetime } from '../utils';
@@ -44,15 +45,19 @@ const FeaturesetsTable = props => (
               </tr>
               {foldedContent}
             </FoldableRow>
-          ); })
+          );
+        })
       }
 
     </table>
   </div>
 );
 FeaturesetsTable.propTypes = {
-  featuresets: React.PropTypes.arrayOf(React.PropTypes.object),
-  featurePlotURL: React.PropTypes.string
+  featuresets: PropTypes.arrayOf(PropTypes.object).isRequired,
+  featurePlotURL: PropTypes.string
+};
+FeaturesetsTable.defaultProps = {
+  featurePlotURL: null
 };
 
 

static/js/components/FeaturizeForm.jsx

@@ -1,4 +1,5 @@
 import React from 'react';
+import PropTypes from 'prop-types';
 import { reduxForm } from 'redux-form';
 import ReactTabs from 'react-tabs';
 
@@ -10,11 +11,7 @@ import { contains } from '../utils';
 import * as Action from '../actions';
 
 
-const Tab = ReactTabs.Tab;
-const Tabs = ReactTabs.Tabs;
-const TabList = ReactTabs.TabList;
-const TabPanel = ReactTabs.TabPanel;
-
+const { Tab, Tabs, TabList, TabPanel } = { ...ReactTabs };
 
 const FeaturizeForm = (props) => {
   const { fields, fields: { datasetID, featuresetName, customFeatsCode },
@@ -69,9 +66,13 @@ const FeaturizeForm = (props) => {
               <TabPanel>
                 <a
                   href="#"
-                  onClick={() => {
+                  onClick={
+                    () => {
                       props.dispatch(Action.groupToggleCheckedFeatures(
-                        props.featuresByCategory[ctgy])); }}
+                        props.featuresByCategory[ctgy]
+                      ));
+                    }
+                  }
                 >
                   Check/Uncheck All
                 </a>
@@ -103,7 +104,8 @@ const FeaturizeForm = (props) => {
           <TabPanel>
             <TextareaInput
               label="Enter Python code defining custom features"
-              rows="10" cols="50"
+              rows="10"
+              cols="50"
               {...customFeatsCode}
             />
           </TabPanel>
@@ -113,19 +115,21 @@ const FeaturizeForm = (props) => {
   );
 };
 FeaturizeForm.propTypes = {
-  fields: React.PropTypes.object.isRequired,
-  datasets: React.PropTypes.arrayOf(React.PropTypes.object).isRequired,
-  error: React.PropTypes.string,
-  handleSubmit: React.PropTypes.func.isRequired,
-  submitting: React.PropTypes.bool.isRequired,
-  resetForm: React.PropTypes.func.isRequired,
-  selectedProject: React.PropTypes.object,
-  featuresByCategory: React.PropTypes.object,
-  tagList: React.PropTypes.arrayOf(React.PropTypes.string).isRequired,
-  featuresList: React.PropTypes.array,
-  featureDescriptions: React.PropTypes.object
+  fields: PropTypes.object.isRequired,
+  datasets: PropTypes.arrayOf(PropTypes.object).isRequired,
+  error: PropTypes.string,
+  handleSubmit: PropTypes.func.isRequired,
+  submitting: PropTypes.bool.isRequired,
+  resetForm: PropTypes.func.isRequired,
+  selectedProject: PropTypes.object.isRequired,
+  featuresByCategory: PropTypes.object.isRequired,
+  tagList: PropTypes.arrayOf(PropTypes.string).isRequired,
+  featuresList: PropTypes.array.isRequired,
+  featureDescriptions: PropTypes.object.isRequired
+};
+FeaturizeForm.defaultProps = {
+  error: ""
 };
-
 
 const mapStateToProps = (state, ownProps) => {
   const featuresList = state.features.featsWithCheckedTags;
@@ -144,7 +148,8 @@ const mapStateToProps = (state, ownProps) => {
     featureDescriptions: state.features.descriptions,
     datasets: filteredDatasets,
     fields: featuresList.concat(
-      ['datasetID', 'featuresetName', 'customFeatsCode']),
+      ['datasetID', 'featuresetName', 'customFeatsCode']
+    ),
     initialValues: { ...initialValues,
                      datasetID: zerothDataset ? zerothDataset.id.toString() : "",
                      customFeatsCode: "" }

static/js/components/UploadFeaturesForm.jsx

@@ -1,4 +1,5 @@
 import React from 'react';
+import PropTypes from 'prop-types';
 import { reduxForm } from 'redux-form';
 
 import { FormComponent, Form, TextInput, TextareaInput, SubmitButton,
@@ -9,8 +10,7 @@ import CesiumTooltip from './Tooltip';
 
 const UploadFeaturesForm = props => {
   const { fields, fields: { datasetID, featuresetName, dataFile },
-          handleSubmit, submitting, resetForm, error, featuresList,
-          featureDescriptions } = props;
+          handleSubmit, submitting, resetForm, error } = props;
   const datasets = props.datasets.map(ds => (
     { id: ds.id,
       label: ds.name }
@@ -47,23 +47,22 @@ const UploadFeaturesForm = props => {
 };
 
 UploadFeaturesForm.propTypes = {
-  fields: React.PropTypes.object.isRequired,
-  datasets: React.PropTypes.arrayOf(React.PropTypes.object).isRequired,
-  error: React.PropTypes.string,
-  handleSubmit: React.PropTypes.func.isRequired,
-  submitting: React.PropTypes.bool.isRequired,
-  resetForm: React.PropTypes.func.isRequired,
-  selectedProject: React.PropTypes.object
+  fields: PropTypes.object.isRequired,
+  datasets: PropTypes.arrayOf(PropTypes.object).isRequired,
+  error: PropTypes.string,
+  handleSubmit: PropTypes.func.isRequired,
+  submitting: PropTypes.bool.isRequired,
+  resetForm: PropTypes.func.isRequired,
+  selectedProject: PropTypes.object.isRequired
+};
+UploadFeaturesForm.defaultProps = {
+  error: ""
 };
-
 
 const mapStateToProps = (state, ownProps) => {
-
   const initialValues = { };
-
   const filteredDatasets = state.datasets.filter(dataset =>
     (dataset.project_id === ownProps.selectedProject.id));
-
   return {
     datasets: filteredDatasets,
     fields: ['datasetID', 'featuresetName', 'dataFile'],
@@ -82,4 +81,5 @@ export default reduxForm(
     form: 'uploadFeatures',
     fields: [''],
     validate
-  }, mapStateToProps)(UploadFeaturesForm);
+  }, mapStateToProps
+)(UploadFeaturesForm);