Don't compare files after mustache rendering

When using template method `"mustache"` and `"inline_mustache"` the
the rendered file is already saved in RenderTemplateMustache(). When
calling FinishEditContext() later on to free up memory, it would compare
the edit context to the rendered file and change the promise result to
NOOP.

Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>

Author: larsewi

cf-agent/files_edit.c

@@ -103,9 +103,9 @@ EditContext *NewEditContext(char *filename, const Attributes *a)
 /*****************************************************************************/
 
 void FinishEditContext(EvalContext *ctx, EditContext *ec, const Attributes *a, const Promise *pp,
-                       PromiseResult *result)
+                       PromiseResult *result, bool do_not_save_file_as)
 {
-    if (*result != PROMISE_RESULT_CHANGE)
+    if (*result != PROMISE_RESULT_CHANGE || do_not_save_file_as)
     {
         // Failure or skipped. Don't update the file.
         goto end;

cf-agent/files_edit.h

@@ -57,7 +57,7 @@ typedef struct
 EditContext *NewEditContext(char *filename, const Attributes *a);
 void FinishEditContext(EvalContext *ctx, EditContext *ec,
                        const Attributes *a, const Promise *pp,
-                       PromiseResult *result);
+                       PromiseResult *result, bool do_not_save_file_as);
 
 #ifdef HAVE_LIBXML2
 bool LoadFileAsXmlDoc(xmlDocPtr *doc, const char *file, EditDefaults ed, bool only_checks);

cf-agent/verify_files.c

@@ -1105,7 +1105,10 @@ PromiseResult ScheduleEditOperation(EvalContext *ctx, char *filename,
     }
 
 exit:
-    FinishEditContext(ctx, edcontext, a, pp, &result);
+    /* With template method "mustache" and "inline_mustache" the file is
+     * already saved. Saving it again will result in PROMISE_RESULT_NOOP */
+    bool do_not_save_file_as = StringEqual(a->template_method, "mustache") || StringEqual(a->template_method, "inline_mustache");
+    FinishEditContext(ctx, edcontext, a, pp, &result, do_not_save_file_as);
     YieldCurrentLock(thislock);
     if (result == PROMISE_RESULT_CHANGE)
     {