Don't compare files after mustache rendering

When using template method `"mustache"` and `"inline_mustache"` the
the rendered file is already saved in RenderTemplateMustache(). When
calling FinishEditContext() later on to free up memory, it would compare
the edit context to the rendered file and change the promise result to
NOOP.

Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>

Author: larsewi

cf-agent/files_edit.c

@@ -103,9 +103,9 @@ EditContext *NewEditContext(char *filename, const Attributes *a)
 /*****************************************************************************/
 
 void FinishEditContext(EvalContext *ctx, EditContext *ec, const Attributes *a, const Promise *pp,
-                       PromiseResult *result)
+                       PromiseResult *result, bool no_compare)
 {
-    if (*result != PROMISE_RESULT_CHANGE)
+    if (*result != PROMISE_RESULT_CHANGE || no_compare)
     {
         // Failure or skipped. Don't update the file.
         goto end;

cf-agent/files_edit.h

@@ -57,7 +57,7 @@ typedef struct
 EditContext *NewEditContext(char *filename, const Attributes *a);
 void FinishEditContext(EvalContext *ctx, EditContext *ec,
                        const Attributes *a, const Promise *pp,
-                       PromiseResult *result);
+                       PromiseResult *result, bool no_compare);
 
 #ifdef HAVE_LIBXML2
 bool LoadFileAsXmlDoc(xmlDocPtr *doc, const char *file, EditDefaults ed, bool only_checks);

cf-agent/verify_files.c

@@ -1105,7 +1105,11 @@ PromiseResult ScheduleEditOperation(EvalContext *ctx, char *filename,
     }
 
 exit:
-    FinishEditContext(ctx, edcontext, a, pp, &result);
+    /* With template method "mustache" and "inline_mustache" the file is
+     * already saved. Hence, comparing the file to the edit context would
+     * result in PROMISE_RESULT_NOOP. */
+    bool no_compare = StringEqual(a->template_method, "mustache") || StringEqual(a->template_method, "inline_mustache");
+    FinishEditContext(ctx, edcontext, a, pp, &result, no_compare);
     YieldCurrentLock(thislock);
     if (result == PROMISE_RESULT_CHANGE)
     {