Fix Psalm errors

Author: AngelFQC

src/CoreBundle/Controller/ChatController.php

@@ -229,7 +229,7 @@ public function globalStart(): JsonResponse
         }
 
         if (\is_string($ret)) {
-            return JsonResponse::fromJsonString($ret);
+            return JsonResponse::fromJsonString((string) $ret);
         }
 
         return new JsonResponse($ret ?? []);

src/CoreBundle/Framework/Container.php

@@ -58,6 +58,7 @@
 use Chamilo\CourseBundle\Repository\CCalendarEventRepository;
 use Chamilo\CourseBundle\Repository\CCourseDescriptionRepository;
 use Chamilo\CourseBundle\Repository\CDocumentRepository;
+use Chamilo\CourseBundle\Repository\CDropboxFileRepository;
 use Chamilo\CourseBundle\Repository\CForumAttachmentRepository;
 use Chamilo\CourseBundle\Repository\CForumCategoryRepository;
 use Chamilo\CourseBundle\Repository\CForumPostRepository;
@@ -480,9 +481,9 @@ public static function getNotebookRepository(): CNotebookRepository
         return self::$container->get(CNotebookRepository::class);
     }
 
-    public static function getDropboxFileRepository(): CDropboxFile
+    public static function getDropboxFileRepository(): CDropboxFileRepository
     {
-        return self::$container->get(CDropboxFile::class);
+        return self::$container->get(CDropboxFileRepository::class);
     }
 
     public static function getPersonalFileRepository(): PersonalFileRepository

src/CoreBundle/State/CBlogAssignAuthorProcessor.php

@@ -16,7 +16,9 @@
 use Symfony\Bundle\SecurityBundle\Security;
 
 /**
- * Assigns current authenticated user as author on POST if none provided.
+ * Assigns the current authenticated user as author on POST if none provided.
+ *
+ * @implements ProcessorInterface<CBlogPost|CBlogComment|CBlogTask, CBlogPost|CBlogComment|CBlogTask>
  */
 final readonly class CBlogAssignAuthorProcessor implements ProcessorInterface
 {

src/CoreBundle/State/LpCollectionStateProvider.php

@@ -16,12 +16,15 @@
 use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Bundle\SecurityBundle\Security;
 
-final class LpCollectionStateProvider implements ProviderInterface
+/**
+ * @template-implements ProviderInterface<CLp>
+ */
+final readonly class LpCollectionStateProvider implements ProviderInterface
 {
     public function __construct(
-        private readonly EntityManagerInterface $em,
-        private readonly CLpRepository $lpRepo,
-        private readonly Security $security
+        private EntityManagerInterface $em,
+        private CLpRepository $lpRepo,
+        private Security $security
     ) {}
 
     public function supports(Operation $op, array $uriVariables = [], array $ctx = []): bool

src/CoreBundle/State/UserSessionSubscriptionsStateProvider.php

@@ -35,7 +35,7 @@ public function __construct(
     /**
      * @throws Exception
      */
-    public function provide(Operation $operation, array $uriVariables = [], array $context = []): iterable
+    public function provide(Operation $operation, array $uriVariables = [], array $context = []): array
     {
         $user = $this->userRepository->find($uriVariables['id']);
 

tests/CoreBundle/Security/Authorization/Voter/CourseVoterTest.php

@@ -11,25 +11,34 @@
 use Chamilo\CoreBundle\Security\Authorization\Voter\CourseVoter;
 use Chamilo\Tests\ChamiloTestTrait;
 use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\ORM\Exception\ORMException;
+use Doctrine\ORM\OptimisticLockException;
+use Generator;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Symfony\Bundle\SecurityBundle\Security;
 use Symfony\Component\Security\Core\Authorization\Voter\VoterInterface;
-use Symfony\Component\Security\Core\Security;
 
 class CourseVoterTest extends WebTestCase
 {
     use ChamiloTestTrait;
 
     // @dataProvider provideVoteTests not working
+
+    /**
+     * @throws OptimisticLockException
+     * @throws ORMException
+     */
     public function testVote(): void
     {
         $client = static::createClient();
         $tests = $this->provideVoteTests();
         $entity_manager = $this->getContainer()->get(EntityManagerInterface::class);
+        $translator = $this->getContainer()->get('translator');
         $request_stack = $this->getMockedRequestStack([
             'query' => ['sid' => 1],
         ]);
         $security = $this->getContainer()->get(Security::class);
-        $voter = new CourseVoter($security, $request_stack, $entity_manager);
+        $voter = new CourseVoter($security, $translator, $request_stack, $entity_manager);
         foreach ($tests as $message => $test) {
             [$expected, $user, $course] = $test;
             $client->loginUser($user);
@@ -38,7 +47,11 @@ public function testVote(): void
         }
     }
 
-    public function provideVoteTests()
+    /**
+     * @throws ORMException
+     * @throws OptimisticLockException
+     */
+    public function provideVoteTests(): Generator
     {
         $em = $this->getEntityManager();
         $admin = $this->getAdmin();