Merge pull request #6876 from christianbeeznest/fixes-updates152

christianbeeznest · web-flow · commit 8ecfada16435 · 2025-10-07T14:00:42.000-05:00
Internal: general fixes and cleanup
diff --git a/src/CoreBundle/Controller/CourseMaintenanceController.php b/src/CoreBundle/Controller/CourseMaintenanceController.php
@@ -1543,9 +1543,7 @@ private function filterLegacyCourseBySelection(object $course, array $selected):
                     }
                 }
 
-                if (empty($qids)) {
-                    // no-op
-                } else {
+                if (!empty($qids)) {
                     $questionBucket = $getBucket($orig, $questionKey);
                     $selQ = array_intersect_key($questionBucket, $qids);
                     if (!empty($selQ)) {

Original file line number	Diff line number	Diff line change
`@@ -1543,9 +1543,7 @@ private function filterLegacyCourseBySelection(object $course, array $selected):`
`1543`	`1543`	`}`
`1544`	`1544`	`}`
`1545`	`1545`
`1546`		`- if (empty($qids)) {`
`1547`		`- // no-op`
`1548`		`- } else {`
	`1546`	`+ if (!empty($qids)) {`
`1549`	`1547`	`$questionBucket = $getBucket($orig, $questionKey);`
`1550`	`1548`	`$selQ = array_intersect_key($questionBucket, $qids);`
`1551`	`1549`	`if (!empty($selQ)) {`