Skip to content

armv7 cross compilation fails with uint64 nr_pages #2756

@rst0git

Description

@rst0git

I just noticed the following errors related to #2750:

#11 12.51 criu/page-xfer.c: In function 'page_server_get_pages':
#11 12.51 criu/page-xfer.c:1148:62: error: passing argument 4 of 'page_pipe_read' from incompatible pointer type [-Wincompatible-pointer-types]
#11 12.51  1148 |         ret = page_pipe_read(pp, &pipe_read_dest, pi->vaddr, &pi->nr_pages, PPB_LAZY);
#11 12.51       |                                                              ^~~~~~~~~~~~~
#11 12.51       |                                                              |
#11 12.51       |                                                              u64 * {aka long long unsigned int *}
#11 12.51 In file included from criu/page-xfer.c:20:
#11 12.51 criu/include/page-pipe.h:152:112: note: expected 'long unsigned int *' but argument is of type 'u64 *' {aka 'long long unsigned int *'}
#11 12.51   152 | extern int page_pipe_read(struct page_pipe *pp, struct pipe_read_dest *prd, unsigned long addr, unsigned long *nr_pages,
#11 12.51       |                                                                                                 ~~~~~~~~~~~~~~~^~~~~~~~
#11 12.52 At top level:
#11 12.52 cc1: note: unrecognized command-line option '-Wno-unknown-warning-option' may have been intended to silence earlier diagnostics
#11 12.52 make[2]: *** [/criu/scripts/nmk/scripts/build.mk:119: criu/page-xfer.o] Error 1
#11 12.52 make[2]: *** Waiting for unfinished jobs....
#11 13.22 make[1]: *** [criu/Makefile:76: criu/built-in.o] Error 2
#11 13.22 make: *** [Makefile:278: criu] Error 2
#11 ERROR: process "/bin/sh -c make mrproper && date && make -j $(nproc) zdtm && date" did not complete successfully: exit code: 2
------
 > [7/7] RUN make mrproper && date && make -j $(nproc) zdtm && date:
12.51 In file included from criu/page-xfer.c:20:
12.51 criu/include/page-pipe.h:152:112: note: expected 'long unsigned int *' but argument is of type 'u64 *' {aka 'long long unsigned int *'}
12.51   152 | extern int page_pipe_read(struct page_pipe *pp, struct pipe_read_dest *prd, unsigned long addr, unsigned long *nr_pages,
12.51       |                                                                                                 ~~~~~~~~~~~~~~~^~~~~~~~

https://github.com/checkpoint-restore/criu/actions/runs/17974695976/job/51125375584?pr=2755

cc @avagin

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions