Skip to content

Commit 5b773b4

Browse files
committed
Remove -Wno-dangling-reference from the windows setup
1 parent 1687c9b commit 5b773b4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.bazelrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ build --workspace_status_command="bash bazel/build-version.sh"
1313
common:unix --cxxopt=-xc++ --host_cxxopt=-xc++ --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --client_env=BAZEL_CXXOPTS=-std=c++17
1414
# Skip -Wno-unknown-warning-option on Windows. It doesn't work.
1515
common:unix --cxxopt="-Wno-unknown-warning-option" --host_cxxopt="-Wno-unknown-warning-option"
16+
# TODO: this looks like benign where it happens but to be explored further. Skip it on Windows. It doesn't work.
17+
common:unix --cxxopt="-Wno-dangling-reference" --host_cxxopt="-Wno-dangling-reference"
1618
common:linux --config=unix
1719
common:freebsd --config=unix --linkopt=-lm --host_linkopt=-lm
1820
common:openbsd --config=unix --linkopt=-lm --host_linkopt=-lm
@@ -28,8 +30,6 @@ common:macos --features=-supports_dynamic_linker --linkopt=-framework --linkopt=
2830
# Since we use designated initializers (C99 ... but >= c++20), compiler really wants the c++20 mode
2931
common:windows --compiler=clang-cl --cxxopt=/std:c++20 --host_cxxopt=/std:c++20 --client_env=BAZEL_CXXOPTS=/std:c++20
3032

31-
# TODO: this looks like benign where it happens but to be explored further
32-
build --cxxopt="-Wno-dangling-reference" --host_cxxopt="-Wno-dangling-reference"
3333
# Newer bisons create an unused label.
3434
build --cxxopt="-Wno-unused-label" --host_cxxopt="-Wno-unused-label"
3535
# c++20 warning on protobuf 28.1

0 commit comments

Comments
 (0)