[analytics] Fix multiple frequencies not shown for the same value

Author: alexander-yakushev

src/orchard/inspect/analytics.clj

@@ -19,9 +19,15 @@
 (defn- *frequencies [coll]
   (let [freqs (->> coll
                    (eduction (take *size-cutoff*))
-                   frequencies)]
+                   frequencies)
+        cmp #(let [res (compare (freqs %1) (freqs %2))]
+               (if (zero? res)
+                 ;; If values are identical, compare hashes of their keys.
+                 ;; Hashes because keys themselves might not be comparable.
+                 (compare (hash %1) (hash %2))
+                 (- res)))]
     ;; Turn the result in a map that is sorted by descending value.
-    (into (sorted-map-by #(- (compare (freqs %1) (freqs %2)))) freqs)))
+    (into (sorted-map-by cmp) freqs)))
 
 (definline ^:private inc-if [val condition]
   `(cond-> ~val ~condition inc))

test/orchard/inspect/analytics_test.clj

@@ -24,7 +24,13 @@
         :types {java.lang.Long 3, nil 3}
         :frequencies {nil 3, 0 1, 1 1, 2 1}
         :numbers {:n 3, :zeros 1, :max 2, :min 0, :mean 1.0}}
-       (analytics [0 nil 1 nil 2 nil])))
+       (analytics [0 nil 1 nil 2 nil]))
+
+  (is+ {:count 5
+        :types {java.lang.Long 5}
+        :frequencies {0 1, 1 1, 2 1, 3 1, 4 1}
+        :numbers {:n 5, :zeros 1, :max 4, :min 0, :mean 2.0}}
+       (analytics (range 5))))
 
 (deftest strings-test
   (is+ {:count 100