[inspect] Don't allow table-viewing maps

Author: alexander-yakushev

src/orchard/inspect.clj

@@ -427,9 +427,9 @@
 (defn supports-table-view-mode?
   "Return whether the inspected object can be rendered in :table view-mode."
   [{:keys [chunk value] :as _inspector}]
-  (let [val (or chunk value)]
-    (and (#{:list :array} (object-type val))
-         (#{:list :array :map} (object-type (first val))))))
+  (let [chunk (or chunk value)]
+    (and (#{:list :array} (object-type value))
+         (#{:list :array :map} (object-type (first chunk))))))
 
 (defn- render-chunk-as-table [inspector chunk idx-starts-from]
   (let [m-i map-indexed

test/orchard/inspect_test.clj

@@ -1566,7 +1566,13 @@
             "  | " [:value "7" pos?] " | " [:value "7" pos?] " | " [:value "7" pos?] " | " [:newline]
             "  | " [:value "8" pos?] " | " [:value "8" pos?] " | " [:value "8" pos?] " | " [:newline]
             [:newline]]
-           (section "Contents" rendered)))))
+           (section "Contents" rendered))))
+
+  (testing "map is not reported as table-viewable when paged"
+    (is (not (-> (zipmap (range 100) (range))
+                 (inspect/start)
+                 (set-page-size 30)
+                 (inspect/supports-table-view-mode?))))))
 
 (deftest pretty-print-map-test
   (testing "in :pretty view-mode are pretty printed"