Skip to content

fix: widget isn't destroyed on unmount #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: widget isn't destroyed on unmount #588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d619d
fix: widget isn't destroyed on unmount
Feb 13, 2025
ced9949
update: preventing handleOnLoad execution if component unmounted
Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion next-cloudinary/src/components/CldUploadWidget/CldUploadWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const CldUploadWidget = ({
}: CldUploadWidgetProps) => {
const cloudinary: CldUploadWidgetCloudinaryInstance = useRef();
const widget: CldUploadWidgetWidgetInstance = useRef();
const isMounted = useRef<boolean>();

const [error, setError] = useState<CloudinaryUploadWidgetError | undefined>(undefined);
const [results, setResults] = useState<CloudinaryUploadWidgetResults | undefined>(undefined);
Expand Down Expand Up @@ -116,6 +117,10 @@ const CldUploadWidget = ({
*/

function handleOnLoad() {
if (!isMounted.current) {
return;
}

setIsScriptLoading(false);

if ( !cloudinary.current ) {
Expand All @@ -132,8 +137,13 @@ const CldUploadWidget = ({
});
}

useEffect(() => {
isMounted.current = true;
},[])

useEffect(() => {
return () => {
isMounted.current = false;
widget.current?.destroy();
widget.current = undefined;
}
Expand Down Expand Up @@ -248,4 +258,4 @@ const CldUploadWidget = ({
);
};

export default CldUploadWidget;
export default CldUploadWidget;