Skip to content

Commit eae4ea1

Browse files
committed
feat(nsc): replace unsafe.Pointer with atomic.Pointer
1 parent 94eee6d commit eae4ea1

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

pkg/controllers/proxy/network_services_controller.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"sync/atomic"
1414
"syscall"
1515
"time"
16-
"unsafe"
1716

1817
"github.com/ccoveille/go-safecast"
1918
"github.com/cloudnativelabs/kube-router/v2/pkg/healthcheck"
@@ -117,7 +116,7 @@ type NetworkServicesController struct {
117116
krNode utils.NodeAware
118117
syncPeriod time.Duration
119118
mu sync.Mutex
120-
serviceMap unsafe.Pointer
119+
serviceMap atomic.Pointer[serviceInfoMap]
121120
endpointsMap endpointSliceInfoMap
122121
podCidr string
123122
excludedCidrs []net.IPNet
@@ -2050,9 +2049,9 @@ func NewNetworkServicesController(clientset kubernetes.Interface,
20502049
}
20512050

20522051
func (nsc *NetworkServicesController) setServiceMap(serviceMap serviceInfoMap) {
2053-
atomic.StorePointer(&nsc.serviceMap, unsafe.Pointer(&serviceMap))
2052+
nsc.serviceMap.Store(&serviceMap)
20542053
}
20552054

20562055
func (nsc *NetworkServicesController) getServiceMap() serviceInfoMap {
2057-
return *(*serviceInfoMap)(atomic.LoadPointer(&nsc.serviceMap))
2056+
return *nsc.serviceMap.Load()
20582057
}

0 commit comments

Comments
 (0)