This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Demonstrate width issues #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantljosh
requested review from
d-laing,
dcoplowe,
mcclowes and
pzaichkina
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CodatLink component seems to not be consistent with whether the consumer is responsible for rendering the modal or if CodatLink is. In this sample, the consumer code has to create the container and position it in the center of the screen, however then the CodatLink component is attempting to be responsible for the width and the box shadows.
In our application we have a design system already in place for modals that renders a scrim, a box shadow, and is responsive with a max width of 480px. It will take up the full 480px if there is space. Below a certain width (i.e. mobile) we position and display our modal differently so it takes the full width.
IMO the CodatLink component needs to either be responsible for the entire "modal" aspect, or continue relying on the conumer placing it in a modal and no defining a fixed width (or if you have to define a fixed width for your content, removing the box shadow and centering the content should be suffcient)