fix export download

Author: gheorghelupu17

app/Notifications/Admin/ExportExcelNotification.php

@@ -45,11 +45,15 @@ public function via(object $notifiable): array
      */
     public function toMail(object $notifiable): MailMessage
     {
+        $file = Storage::disk('filament-excel')->exists($this->filename)
+            ? Storage::disk('filament-excel')->get($this->filename)
+            : null;
+
         return (new MailMessage)
             ->subject(__('notification.export_finished.title'))
             ->line(__('notification.export_finished.body', ['filename' => $this->filename]))
-            ->attach(Storage::disk('filament-excel')->path($this->filename))
-            ->action(__('notification.export_finished.action'), Storage::disk('filament-excel')->url($this->filename));
+            ->attachData($file, $this->filename)
+            ->action(__('notification.export_finished.action'), $this->generateURL());
     }
 
     /**

routes/web.php

@@ -84,10 +84,11 @@
 });
 
 Route::get('filament-excel/{path}', function (string $path) {
-    return
-        response()
-            ->download(Storage::disk('filament-excel')->path($path), substr($path, 37))
-            ->deleteFileAfterSend();
+    if (! Storage::disk('filament-excel')->exists($path)) {
+        abort(404);
+    }
+
+    return Storage::disk('filament-excel')->download($path);
 })
     ->where('path', '.*')
     ->name('filament-excel-download');