Skip to content

Commit 05ddcc1

Browse files
fix newsllatter subscription
1 parent f7ea946 commit 05ddcc1

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

app/Services/NewsletterService.php

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,14 @@ class NewsletterService
1111
{
1212
public static function subscribe(string $email, ?string $name = null)
1313
{
14-
$mergeFields = [
15-
'MERGE1' => $name,
16-
];
14+
$mergeFields = [];
15+
if (filled($name))
16+
{
17+
$mergeFields = [
18+
'MERGE1' => $name,
19+
];
1720

21+
}
1822
$response = rescue(
1923
fn () => Newsletter::subscribe($email, $mergeFields),
2024
false
@@ -24,11 +28,11 @@ public static function subscribe(string $email, ?string $name = null)
2428
Log::error('Failed to subscribe user to newsletter', [
2529
'email' => $email,
2630
'response' => $response,
31+
'error' => Newsletter::getApi()->getLastError(),
2732
]);
2833

2934
// TODO: check if email registered as user
30-
// and assign subscriber badge if the
31-
// user doesn't already have one.
35+
3236
}
3337

3438
return $response;

0 commit comments

Comments
 (0)