Fix deletePropertyFromObject bug; If null was inside an array would cause the code to break. (#23)

* Fix deletePropertyFromObject bug; If null was inside an array would cause the code to break.

* update packages

Author: codeBelt

README.md

@@ -320,6 +320,8 @@ export default class CarModel extends BaseModel {
 
 ## Release History
 
+-   2020-07-29 v1.9.1 Fix deletePropertyFromObject bug; If null was inside an array would cause the code to break.
+
 -   2019-06-23 v1.9.0 IConvertOption now happens before data is assigned to properties. Now if you use ConversionTypeEnum.JSON and have a default model it will create that new model instead of having a plain object.
 
 -   2019-01-28 v1.8.2 ConversionTypeEnum.String now coverts objects with JSON.stringify.

__tests__/Util.test.ts

@@ -24,8 +24,18 @@ describe('Util', () => {
     });
 
     test('Util.deletePropertyFromObject()', () => {
-        const obj: any = {name: 'Robert', gender: 'male', phone: '555-555-5555'};
-        const expected: any = {name: 'Robert'};
+        const obj: any = {
+            name: 'Robert',
+            gender: 'male',
+            phone: '555-555-5555',
+            nested: {name: 'Robert', gender: 'male', phone: '555-555-5555'},
+            arrayWithNullAlso: [{name: 'Robert', gender: 'male', phone: '555-555-5555'}, null, 0, 'one', true],
+        };
+        const expected: any = {
+            name: 'Robert',
+            nested: {name: 'Robert'},
+            arrayWithNullAlso: [{name: 'Robert'}, null, 0, 'one', true],
+        };
         const actual: any = Util.deletePropertyFromObject(obj, ['phone', 'gender']);
 
         expect(expected).toEqual(actual);

package.json

@@ -25,7 +25,7 @@
     "prewatch": "npm run clean && npm run build:types",
     "watch": "rollup -cw",
     "---------- BUILD -------------------------------------------": "",
-    "prebuild": "npm run type-check && npm run clean && npm run build:types",
+    "prebuild": "npm run type-check && npm run test && npm run clean && npm run build:types",
     "build": "rollup -c",
     "---------- TESTING -----------------------------------------": "",
     "test": "npm run lint && npm run unit",
@@ -47,29 +47,29 @@
   "dependencies": {},
   "license": "MIT",
   "devDependencies": {
-    "@babel/core": "7.4.5",
-    "@babel/plugin-proposal-class-properties": "7.4.4",
-    "@babel/plugin-proposal-object-rest-spread": "7.4.4",
-    "@babel/plugin-transform-runtime": "7.4.4",
-    "@babel/preset-env": "7.4.5",
-    "@babel/preset-typescript": "7.3.3",
-    "@babel/runtime": "7.4.5",
-    "@types/jest": "24.0.15",
-    "husky": "2.4.1",
-    "jest": "24.8.0",
-    "prettier": "1.18.2",
-    "pretty-quick": "1.11.1",
-    "rimraf": "2.6.3",
+    "@babel/core": "7.10.5",
+    "@babel/plugin-proposal-class-properties": "7.10.4",
+    "@babel/plugin-proposal-object-rest-spread": "7.10.4",
+    "@babel/plugin-transform-runtime": "7.10.5",
+    "@babel/preset-env": "7.10.4",
+    "@babel/preset-typescript": "7.10.4",
+    "@babel/runtime": "7.10.5",
+    "@types/jest": "26.0.7",
+    "husky": "4.2.5",
+    "jest": "26.1.0",
+    "prettier": "2.0.5",
+    "pretty-quick": "2.0.1",
+    "rimraf": "3.0.2",
     "rollup": "1.16.1",
-    "rollup-plugin-babel": "4.3.2",
-    "rollup-plugin-commonjs": "10.0.0",
-    "rollup-plugin-node-resolve": "5.0.3",
-    "rollup-plugin-uglify": "6.0.2",
-    "ts-jest": "24.0.2",
-    "tslib": "1.10.0",
-    "tslint": "5.18.0",
+    "rollup-plugin-babel": "4.4.0",
+    "rollup-plugin-commonjs": "10.1.0",
+    "rollup-plugin-node-resolve": "5.2.0",
+    "rollup-plugin-uglify": "6.0.4",
+    "ts-jest": "26.1.4",
+    "tslib": "2.0.0",
+    "tslint": "6.1.2",
     "tslint-config-prettier": "1.18.0",
-    "typescript": "3.5.2"
+    "typescript": "3.9.7"
   },
   "author": {
     "name": "Robert S. (codeBelt)",

src/Util.ts

@@ -61,6 +61,10 @@ export class Util {
      *      // { name: 'Robert' }
      */
     public static deletePropertyFromObject(object: any, value: string | string[]): any {
+        if (!Util.isObject(object)) {
+            return object;
+        }
+
         // If properties is not an array then make it an array object.
         const propertyNameList: any = value instanceof Array ? value : [value];
 
@@ -71,7 +75,7 @@ export class Util {
                 delete object[key];
             } else if (propertyData instanceof Array) {
                 propertyData.forEach((item: any) => Util.deletePropertyFromObject(item, propertyNameList));
-            } else if (propertyData instanceof Object) {
+            } else if (Util.isObject(propertyData)) {
                 Util.deletePropertyFromObject(propertyData, propertyNameList);
             }
         });