Merge pull request #8 from codeclimate/abh-gemfile-lock

Raise error when Gemfile.lock not present

Author: Ashley Baldwin-Hunter

lib/cc/engine/bundler_audit.rb

@@ -4,6 +4,8 @@
 module CC
   module Engine
     class BundlerAudit
+      GemfileLockNotFound = Class.new(StandardError)
+
       def initialize(directory: , io: , engine_config: )
         @directory = directory
         @engine_config = engine_config
@@ -25,11 +27,7 @@ def run
             @io.print("#{issue.to_json}\0")
           end
         else
-          warning = {
-            type: "warning",
-            description: "No Gemfile.lock file found"
-          }
-          @io.print("#{warning.to_json}\0")
+          raise GemfileLockNotFound, "No Gemfile.lock found."
         end
       end
 

spec/cc/engine/bundler_audit_spec.rb

@@ -3,16 +3,15 @@
 module CC::Engine
   describe BundlerAudit do
     describe "#run" do
-      it "emits a warning when no Gemfile exists" do
+      it "raises an error when no Gemfile.lock exists" do
         FakeFS do
           directory = "/c"
           FileUtils.mkdir_p(directory)
           io = StringIO.new
           config = {}
 
-          BundlerAudit.new(directory: directory, io: io, engine_config: config).run
-
-          expect(io.string).to match(%{{"type":"warning","description":"No Gemfile.lock file found"}})
+          expect { BundlerAudit.new(directory: directory, io: io, engine_config: config).run }
+            .to raise_error(CC::Engine::BundlerAudit::GemfileLockNotFound)
         end
       end