Skip to content

Commit 182d88a

Browse files
committed
Run docker build as a dependency, not a test step
Not overriding the dependency step can cause Circle to infer ruby and run a bundle install. That can leave files in the source tree that end up copied into the docker image and mess with bundler's operation within that image. Also, the build step is (IMO) a dependency, not itself a test.
1 parent d9b10a3 commit 182d88a

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

circle.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,12 @@ machine:
55
CLOUDSDK_CORE_DISABLE_PROMPTS: 1
66
PRIVATE_REGISTRY: us.gcr.io/code_climate
77

8-
test:
8+
dependencies:
99
override:
1010
- docker build -t=$PRIVATE_REGISTRY/$CIRCLE_PROJECT_REPONAME:b$CIRCLE_BUILD_NUM .
11+
12+
test:
13+
override:
1114
- docker run $PRIVATE_REGISTRY/$CIRCLE_PROJECT_REPONAME:b$CIRCLE_BUILD_NUM bundle exec rake
1215

1316
deployment:

0 commit comments

Comments
 (0)