Merge pull request #79 from codeclimate/gd-issue-tickets

Add Issue type

Author: gdiggs

lib/cc/helpers/issue_helper.rb

@@ -0,0 +1,9 @@
+module CC::Service::IssueHelper
+  def constant_name
+    payload["constant_name"]
+  end
+
+  def issue
+    payload["issue"]
+  end
+end

lib/cc/service.rb

@@ -30,7 +30,7 @@ def self.load_services
 
     attr_reader :event, :config, :payload
 
-    ALL_EVENTS = %w[test unit coverage quality vulnerability snapshot pull_request]
+    ALL_EVENTS = %w[test unit coverage quality vulnerability snapshot pull_request issue]
 
     # Tracks the defined services.
     def self.services

lib/cc/services/asana.rb

@@ -31,6 +31,13 @@ def receive_test
     raise ex
   end
 
+  def receive_issue
+    title = %{Fix "#{issue["check_name"]}" issue in #{constant_name}}
+
+    body = [issue["description"], details_url].join("\n\n")
+
+    create_task(title, body)
+  end
 
   def receive_quality
     title = "Refactor #{constant_name} from #{rating} on Code Climate"
@@ -47,8 +54,8 @@ def receive_vulnerability
 
 private
 
-  def create_task(name)
-    params = generate_params(name)
+  def create_task(name, notes = nil)
+    params = generate_params(name, notes)
     authenticate_http
     http.headers["Content-Type"] = "application/json"
     service_post(ENDPOINT, params.to_json) do |response|
@@ -59,9 +66,9 @@ def create_task(name)
     end
   end
 
-  def generate_params(name)
+  def generate_params(name, notes = nil)
     params = {
-      data: { workspace: config.workspace_id, name: name }
+      data: { workspace: config.workspace_id, name: name, notes: notes }
     }
 
     if config.project_id.present?

lib/cc/services/github_issues.rb

@@ -45,6 +45,14 @@ def receive_vulnerability
     )
   end
 
+  def receive_issue
+    title = %{Fix "#{issue["check_name"]}" issue in #{constant_name}}
+
+    body = [issue["description"], details_url].join("\n\n")
+
+    create_issue(title, body)
+  end
+
 private
 
   def create_issue(title, issue_body)

lib/cc/services/jira.rb

@@ -41,6 +41,14 @@ def receive_quality
     create_ticket(title, details_url)
   end
 
+  def receive_issue
+    title = %{Fix "#{issue["check_name"]}" issue in #{constant_name}}
+
+    body = [issue["description"], details_url].join("\n\n")
+
+    create_ticket(title, body)
+  end
+
   def receive_vulnerability
     formatter = CC::Formatters::TicketFormatter.new(self)
 

lib/cc/services/lighthouse.rb

@@ -35,6 +35,14 @@ def receive_quality
     create_ticket(title, details_url)
   end
 
+  def receive_issue
+    title = %{Fix "#{issue["check_name"]}" issue in #{constant_name}}
+
+    body = [issue["description"], details_url].join("\n\n")
+
+    create_ticket(title, body)
+  end
+
   def receive_vulnerability
     formatter = CC::Formatters::TicketFormatter.new(self)
 

lib/cc/services/pivotal_tracker.rb

@@ -33,6 +33,14 @@ def receive_quality
     create_story(name, details_url)
   end
 
+  def receive_issue
+    title = %{Fix "#{issue["check_name"]}" issue in #{constant_name}}
+
+    body = [issue["description"], details_url].join("\n\n")
+
+    create_story(title, body)
+  end
+
   def receive_vulnerability
     formatter = CC::Formatters::TicketFormatter.new(self)
 

test/asana_test.rb

@@ -18,6 +18,23 @@ def test_vulnerability
     )
   end
 
+  def test_issue
+    payload = {
+      issue: {
+        "check_name" => "Style/LongLine",
+        "description" => "Line is too long [1000/80]"
+      },
+      constant_name: "foo.rb",
+      details_url: "http://example.com/repos/id/foo.rb#issue_123"
+    }
+
+    assert_asana_receives(
+      event(:issue, payload),
+      "Fix \"Style/LongLine\" issue in foo.rb",
+      "Line is too long [1000/80]\n\nhttp://example.com/repos/id/foo.rb#issue_123"
+    )
+  end
+
   def test_successful_post
     @stubs.post '/api/1.0/tasks' do |env|
       [200, {}, '{"data":{"id":"2"}}']
@@ -41,7 +58,7 @@ def test_receive_test
 
   private
 
-  def assert_asana_receives(event_data, name)
+  def assert_asana_receives(event_data, name, notes = nil)
     @stubs.post '/api/1.0/tasks' do |env|
       body = JSON.parse(env[:body])
       data = body["data"]
@@ -50,6 +67,7 @@ def assert_asana_receives(event_data, name)
       assert_equal "2",             data["projects"].first
       assert_equal "jim@asana.com", data["assignee"]
       assert_equal name,            data["name"]
+      assert_equal notes,           data["notes"]
 
       [200, {}, '{"data":{"id":4}}']
     end

test/fixtures.rb

@@ -51,6 +51,10 @@ def vulnerability
     options.merge(name: "vulnerability")
   end
 
+  def issue
+    options.merge(name: "issue")
+  end
+
 end
 
 def event(name, options = {})

test/github_issues_test.rb

@@ -22,6 +22,23 @@ def test_quality
     )
   end
 
+  def test_issue
+    payload = {
+      issue: {
+        "check_name" => "Style/LongLine",
+        "description" => "Line is too long [1000/80]"
+      },
+      constant_name: "foo.rb",
+      details_url: "http://example.com/repos/id/foo.rb#issue_123"
+    }
+
+    assert_github_receives(
+      event(:issue, payload),
+      "Fix \"Style/LongLine\" issue in foo.rb",
+      "Line is too long [1000/80]\n\nhttp://example.com/repos/id/foo.rb#issue_123"
+    )
+  end
+
   def test_vulnerability
     assert_github_receives(
       event(:vulnerability, vulnerabilities: [{