Merge pull request #2979 from codecrafters-io/refactor-remove-upcoming-payment-logic

refactor: remove upcoming payment logic from affiliate referral

Author: rohitpaulk

app/components/affiliate-page/affiliate-referred-user-item.hbs

@@ -32,15 +32,6 @@
       </Pill>
     {{/if}}
 
-    {{#if (gt @affiliateReferral.upcomingPaymentAmountInDollars 0)}}
-      <Pill @color="yellow" class="shrink-0">
-        ${{@affiliateReferral.upcomingPaymentAmountInDollars}}
-        pending
-
-        <EmberTooltip @text="This is the value of {{@affiliateReferral.customer.username}}'s upcoming payment." />
-      </Pill>
-    {{/if}}
-
     {{#if @affiliateReferral.statusIsAwaitingFirstCharge}}
       <Pill @color="gray" class="shrink-0">
         Signed up

app/models/affiliate-referral.ts

@@ -10,7 +10,6 @@ export default class AffiliateReferralModel extends Model {
   @attr('date') declare activatedAt: Date;
   @attr('string') declare status: 'awaiting_first_charge' | 'first_charge_successful' | 'inactive';
   @attr('number') declare spentAmountInCents: number;
-  @attr('number') declare upcomingPaymentAmountInCents: number;
   @attr('number') declare withdrawableEarningsAmountInCents: number;
   @attr('number') declare withheldEarningsAmountInCents: number;
 
@@ -37,8 +36,4 @@ export default class AffiliateReferralModel extends Model {
   get totalEarningsAmountInDollars() {
     return this.totalEarningsAmountInCents / 100;
   }
-
-  get upcomingPaymentAmountInDollars() {
-    return this.upcomingPaymentAmountInCents / 100;
-  }
 }

tests/acceptance/affiliate-page/view-affiliate-referrals-test.js

@@ -116,16 +116,15 @@ module('Acceptance | affiliate-page | view-affiliate-referrals', function (hooks
       referrer: this.server.schema.users.first(),
       affiliateLink: affiliateLink,
       activatedAt: new Date(new Date().getTime() - 1000 * 60 * 60 * 24 * 7), // 7 days ago
-      status: 'pending_trial',
+      status: 'awaiting_first_charge',
     });
 
     this.server.create('affiliate-referral', {
       customer: customer2,
       referrer: this.server.schema.users.first(),
       affiliateLink: affiliateLink,
       activatedAt: new Date(new Date().getTime() - 1000 * 60 * 60 * 24 * 3), // 3 days ago
-      status: 'trialing',
-      upcomingPaymentAmountInCents: 59000,
+      status: 'awaiting_first_charge',
     });
 
     this.server.create('affiliate-referral', {
@@ -198,16 +197,15 @@ module('Acceptance | affiliate-page | view-affiliate-referrals', function (hooks
       referrer: this.server.schema.users.first(),
       affiliateLink: affiliateLink,
       activatedAt: new Date(new Date().getTime() - 1000 * 60 * 60 * 24 * 7), // 7 days ago
-      status: 'pending_trial',
+      status: 'awaiting_first_charge',
     });
 
     this.server.create('affiliate-referral', {
       customer: customer2,
       referrer: this.server.schema.users.first(),
       affiliateLink: affiliateLink,
       activatedAt: new Date(new Date().getTime() - 1000 * 60 * 60 * 24 * 3), // 3 days ago
-      status: 'trialing',
-      upcomingPaymentAmountInCents: 59000,
+      status: 'awaiting_first_charge',
     });
 
     this.server.create('affiliate-referral', {
@@ -278,16 +276,15 @@ module('Acceptance | affiliate-page | view-affiliate-referrals', function (hooks
       referrer: this.server.schema.users.first(),
       affiliateLink: affiliateLink,
       activatedAt: new Date(new Date().getTime() - 1000 * 60 * 60 * 24 * 7), // 7 days ago
-      status: 'pending_trial',
+      status: 'awaiting_first_charge',
     });
 
     this.server.create('affiliate-referral', {
       customer: customer2,
       referrer: this.server.schema.users.first(),
       affiliateLink: affiliateLink,
       activatedAt: new Date(new Date().getTime() - 1000 * 60 * 60 * 24 * 3), // 3 days ago
-      status: 'trialing',
-      upcomingPaymentAmountInCents: 59000,
+      status: 'awaiting_first_charge',
     });
 
     this.server.create('affiliate-referral', {