Skip to content

Commit 5745df2

Browse files
authored
Merge pull request #2943 from codecrafters-io/update-pill
Remove pills from latest releases card
2 parents ab31b57 + 8904aec commit 5745df2

File tree

4 files changed

+3
-17
lines changed

4 files changed

+3
-17
lines changed

app/components/latest-releases-card.hbs

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,10 @@
66
<div class="flex items-start gap-2 relative {{if (not-eq releaseIndex (sub this.releases.length 1)) 'pb-4'}}" data-test-latest-release-item>
77
<div class="w-2 h-2 bg-gray-200 dark:bg-gray-600 rounded-full mt-1 flex-shrink-0"></div>
88
<div class="w-full">
9-
<div class="flex items-center gap-1 mb-1">
10-
<div class="text-xxs text-gray-400 dark:text-gray-500" data-test-latest-release-timestamp>{{date-format
11-
release.releasedAt
12-
format="MMM yyyy"
13-
}}</div>
14-
<span class="text-gray-300 dark:text-gray-600 text-xs">
15-
16-
</span>
17-
<Pill @color="gray" @size="small" data-test-latest-release-type>
18-
{{if (eq release.type "extension") "EXTENSION" "CHALLENGE"}}
19-
</Pill>
9+
<div class="text-xs text-gray-400 dark:text-gray-500 mb-1" data-test-latest-release-timestamp>
10+
{{date-format release.releasedAt format="MMM yyyy"}}
2011
</div>
12+
2113
<a
2214
href="{{or release.announcementUrl 'https://forum.codecrafters.io/c/announcements'}}"
2315
target="_blank"

tests/acceptance/roadmap-page/course-extension-ideas-test.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,10 +260,7 @@ module('Acceptance | roadmap-page | course-extension-ideas', function (hooks) {
260260
const releaseItems = roadmapPage.latestReleasesCard.releaseItems;
261261
assert.strictEqual(releaseItems.length, 3, 'should show 3 release items');
262262
assert.strictEqual(releaseItems[0].title, 'Redis / Persistence', 'should show the released extension');
263-
assert.strictEqual(releaseItems[0].type, 'EXTENSION', 'should show correct type');
264263
assert.strictEqual(releaseItems[1].title, 'Build your own Regex Parser', 'should show the released challenge');
265-
assert.strictEqual(releaseItems[1].type, 'CHALLENGE', 'should show correct type');
266264
assert.strictEqual(releaseItems[2].title, 'Build your own SQLite', 'should show the released challenge');
267-
assert.strictEqual(releaseItems[2].type, 'CHALLENGE', 'should show correct type');
268265
});
269266
});

tests/acceptance/roadmap-page/course-ideas-test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -273,11 +273,9 @@ module('Acceptance | roadmap-page | course-ideas', function (hooks) {
273273
assert.deepEqual(timestamps, expectedTimestamps, 'items should be sorted by release date');
274274

275275
assert.strictEqual(releaseItems[0].title, 'Redis / Persistence', 'first item should be most recent');
276-
assert.strictEqual(releaseItems[0].type, 'EXTENSION', 'first item should be extension type');
277276
assert.strictEqual(releaseItems[0].timestamp, 'Jun 2024', 'first item should have correct timestamp');
278277

279278
assert.strictEqual(releaseItems[4].title, 'Build your own HTTP Server', 'last item should be oldest of the 5 shown');
280-
assert.strictEqual(releaseItems[4].type, 'CHALLENGE', 'last item should be challenge type');
281279
assert.strictEqual(releaseItems[4].timestamp, 'Feb 2024', 'last item should have correct timestamp');
282280
});
283281
});

tests/pages/roadmap-page.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export default createPage({
2424
releaseItems: collection('[data-test-latest-release-item]', {
2525
timestamp: text('[data-test-latest-release-timestamp]'),
2626
title: text('[data-test-latest-release-title]'),
27-
type: text('[data-test-latest-release-type]'),
2827
}),
2928
scope: '[data-test-latest-releases-card]',
3029
},

0 commit comments

Comments
 (0)