Skip to content

Commit 140e888

Browse files
authored
Merge pull request #1 from Kutashov/master
Some critical fixes
2 parents 5c054ab + 5029365 commit 140e888

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

RxSocketClient/src/main/java/moe/codeest/rxsocketclient/SocketObservable.kt

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,16 +44,16 @@ class SocketObservable(val mConfig: SocketConfig, val mSocket: Socket) : Observa
4444
observerWrapper = SocketObserver(observer)
4545
observer?.onSubscribe(observerWrapper)
4646

47-
try {
48-
Thread(Runnable {
49-
mSocket.connect(InetSocketAddress(mConfig.mIp, mConfig.mPort?: 1080), mConfig.mTimeout?: 0)
47+
Thread(Runnable {
48+
try {
49+
mSocket.connect(InetSocketAddress(mConfig.mIp, mConfig.mPort ?: 1080), mConfig.mTimeout ?: 0)
5050
observer?.onNext(DataWrapper(SocketState.OPEN, ByteArray(0)))
5151
mReadThread.start()
52-
}).start()
53-
} catch (e: IOException) {
54-
println(e.toString())
55-
observer?.onNext(DataWrapper(SocketState.CLOSE, ByteArray(0)))
56-
}
52+
} catch (e: IOException) {
53+
println(e.toString())
54+
observer?.onNext(DataWrapper(SocketState.CLOSE, ByteArray(0)))
55+
}
56+
}).start()
5757
}
5858

5959
fun setHeartBeatRef(ref: Disposable) {
@@ -102,7 +102,7 @@ class SocketObservable(val mConfig: SocketConfig, val mSocket: Socket) : Observa
102102
observerWrapper.onNext(buffer)
103103
}
104104
}
105-
}catch (e: Exception) {
105+
} catch (e: Exception) {
106106

107107
}
108108
}

RxSocketClient/src/main/java/moe/codeest/rxsocketclient/post/AsyncPoster.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class AsyncPoster(private val mSocketClient: SocketClient, private val mExecutor
3838

3939
override fun run() {
4040
val pendingPost = queue.poll() ?: throw IllegalStateException("No pending post available")
41-
mSocketClient.mSocket.getOutputStream()?.apply {
41+
mSocketClient.mSocket.takeIf { it.isConnected }?.getOutputStream()?.apply {
4242
try {
4343
write(pendingPost.data)
4444
flush()

app/src/main/java/moe/codeest/rxsocketclientdemo/JavaActivity.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,9 @@ public void onClick(View v) {
133133

134134
case R.id.btn_disconnect:
135135
//disconnect
136-
mClient.disconnect();
136+
if (mClient.isConnecting()) {
137+
mClient.disconnect();
138+
}
137139

138140
//or disconnect
139141
// ref.dispose();

0 commit comments

Comments
 (0)