Skip to content

Commit 76f6ff4

Browse files
committed
Fix alpine check
1 parent 2458cde commit 76f6ff4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

scripts/build.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ class Builder {
106106
// (like --version) it outputs the version to stderr and exits with 1.
107107
const result = await util.promisify(cp.exec)("ldd --version")
108108
.catch((error) => ({ stderr: error.message, stdout: "" }));
109-
if (/^musl/.test(result.stderr) || /^musl/.test(result.stdout)) {
109+
if (/musl/.test(result.stderr) || /musl/.test(result.stdout)) {
110110
this._target = "alpine";
111111
} else {
112112
this._target = "linux";
@@ -130,8 +130,8 @@ class Builder {
130130

131131
/**
132132
* Return true if it looks like we're inside VS Code. This is used to prevent
133-
* accidentally building inside while developing or to prevent trying to run
134-
* `yarn` in VS Code when we aren't in VS Code.
133+
* accidentally building inside VS Code while developing which causes issues
134+
* because the watcher will try compiling those built files.
135135
*/
136136
private isInVscode(pathToCheck: string): boolean {
137137
let inside = false;

src/node/update.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ export class UpdateService extends AbstractUpdateService {
130130
stderr: error.message,
131131
stdout: "",
132132
}));
133-
if (/^musl/.test(result.stderr) || /^musl/.test(result.stdout)) {
133+
if (/musl/.test(result.stderr) || /musl/.test(result.stdout)) {
134134
target = "alpine";
135135
}
136136
}

0 commit comments

Comments
 (0)