review existing code as well (#70)

<!-- This is an auto-generated comment: release notes by openai -->
### Summary by OpenAI

**Release Notes**

This pull request includes several changes to the codebase, including
adding "typos" to the list of issues that can be uncovered, updating
`max_tokens_for_extra_content` values for certain models, and adding a
comment to the pull request if the review response does not include
"LGTM". Additionally, the `comment` method in `src/commenter.ts` now
accepts a `tag` and `mode` parameter, and the `post_comment` method has
been removed. These changes aim to improve code quality and streamline
the review process.
<!-- end of auto-generated comment: release notes by openai -->

Author: harjotgill

action.yml

@@ -74,7 +74,7 @@ inputs:
       ability to review code changes thoroughly.You can uncover issues such as 
       logic errors, syntax errors, out of bound errors, potential data races, 
       livelocks, starvation, suspension, order violation, atomicity violation, 
-      consistency, complexity, error handling, and more.
+      consistency, complexity, error handling, typos, and more.
 
       You will be conducting code reviews today and write code if asked to do so.
   summarize_beginning:
@@ -168,7 +168,9 @@ inputs:
       $file_content
       ```
 
-      Reply "OK" to confirm.
+      Reply "LGTM!" if the existing code in this file looks correct. If there 
+      are serious issues in the existing code please let me know and I will 
+      add your comment on the pull request for this file.
   review_file_diff:
     required: false
     description: 'The prompt for each file diff'

dist/index.js

@@ -30,7 +30,40 @@ export class Commenter {
    * @param mode Can be "create", "replace", "append" and "prepend". Default is "replace".
    */
   async comment(message: string, tag: string, mode: string) {
-    await this.post_comment(message, tag, mode)
+    let target: number
+    if (context.payload.pull_request) {
+      target = context.payload.pull_request.number
+    } else if (context.payload.issue) {
+      target = context.payload.issue.number
+    } else {
+      core.warning(
+        `Skipped: context.payload.pull_request and context.payload.issue are both null`
+      )
+      return
+    }
+
+    if (!tag) {
+      tag = COMMENT_TAG
+    }
+
+    const body = `${COMMENT_GREETING}
+
+${message}
+
+${tag}`
+
+    if (mode === 'create') {
+      await this.create(body, target)
+    } else if (mode === 'replace') {
+      await this.replace(body, tag, target)
+    } else if (mode === 'append') {
+      await this.append(body, tag, target)
+    } else if (mode === 'prepend') {
+      await this.prepend(body, tag, target)
+    } else {
+      core.warning(`Unknown mode: ${mode}, use "replace" instead`)
+      await this.replace(body, tag, target)
+    }
   }
 
   get_description(description: string) {
@@ -100,19 +133,20 @@ export class Commenter {
     commit_id: string,
     path: string,
     line: number,
-    message: string
+    message: string,
+    tag: string = COMMENT_TAG
   ) {
     message = `${COMMENT_GREETING}
 
 ${message}
 
-${COMMENT_TAG}`
+${tag}`
     // replace comment made by this action
     try {
       let found = false
       const comments = await this.get_comments_at_line(pull_number, path, line)
       for (const comment of comments) {
-        if (comment.body.includes(COMMENT_TAG)) {
+        if (comment.body.includes(tag)) {
           await octokit.pulls.updateReviewComment({
             owner: repo.owner,
             repo: repo.repo,
@@ -319,43 +353,6 @@ ${chain}
     }
   }
 
-  async post_comment(message: string, tag: string, mode: string) {
-    let target: number
-    if (context.payload.pull_request) {
-      target = context.payload.pull_request.number
-    } else if (context.payload.issue) {
-      target = context.payload.issue.number
-    } else {
-      core.warning(
-        `Skipped: context.payload.pull_request and context.payload.issue are both null`
-      )
-      return
-    }
-
-    if (!tag) {
-      tag = COMMENT_TAG
-    }
-
-    const body = `${COMMENT_GREETING}
-
-${message}
-
-${tag}`
-
-    if (mode === 'create') {
-      await this.create(body, target)
-    } else if (mode === 'replace') {
-      await this.replace(body, tag, target)
-    } else if (mode === 'append') {
-      await this.append(body, tag, target)
-    } else if (mode === 'prepend') {
-      await this.prepend(body, tag, target)
-    } else {
-      core.warning(`Unknown mode: ${mode}, use "replace" instead`)
-      await this.replace(body, tag, target)
-    }
-  }
-
   async create(body: string, target: number) {
     try {
       await octokit.issues.createComment({

src/commenter.ts

@@ -228,9 +228,9 @@ export class Options {
     this.openai_concurrency_limit = parseInt(openai_concurrency_limit)
 
     if (this.openai_model === 'gpt-4') {
-      this.max_tokens_for_extra_content = 5000
+      this.max_tokens_for_extra_content = 4000
     } else if (this.openai_model === 'gpt-3.5-turbo') {
-      this.max_tokens_for_extra_content = 2500
+      this.max_tokens_for_extra_content = 2000
     } else {
       this.max_tokens_for_extra_content = 1000
     }

src/options.ts

@@ -280,6 +280,14 @@ Tips:
                   core.info('review: nothing obtained from openai')
                 } else {
                   next_review_ids = review_file_ids
+                  if (!resp.includes('LGTM')) {
+                    // TODO: add file level comments via API once it's available
+                    // See: https://github.blog/changelog/2023-03-14-comment-on-files-in-a-pull-request-public-beta/
+                    // For now comment on the PR itself
+                    const tag = `<!-- openai-review-file-${filename} -->`
+                    const comment = `${tag}\nReviewing existing code in: ${filename}\n\n${resp}`
+                    await commenter.comment(comment, tag, 'replace')
+                  }
                 }
               } catch (error) {
                 core.warning(`review: error from openai: ${error}`)