fix: compare with base vs. last commit (#223)

harjotgill · web-flow · commit d3b8a17827d1 · 2023-04-20T18:14:09.000-07:00
diff --git a/src/review.ts b/src/review.ts
@@ -121,11 +121,11 @@ export const codeReview = async (
     core.warning(`Skipped: files data is missing`)
     return
   }
-  // Filter out any file that is not changed compared to the target branch
-  const files = incrementalFiles.filter(incrementalChange =>
-    targetBranchFiles.some(
-      changeRelativeToTargetBranch =>
-        changeRelativeToTargetBranch.filename === incrementalChange.filename
+
+  // Filter out any file that is changed compared to the incremental changes
+  const files = targetBranchFiles.filter(targetBranchFile =>
+    incrementalFiles.some(
+      incrementalFile => incrementalFile.filename === targetBranchFile.filename
     )
   )
 

Original file line number	Diff line number	Diff line change
`@@ -121,11 +121,11 @@ export const codeReview = async (`
`121`	`121`	core.warning(`Skipped: files data is missing`)
`122`	`122`	`return`
`123`	`123`	`}`
`124`		`- // Filter out any file that is not changed compared to the target branch`
`125`		`- const files = incrementalFiles.filter(incrementalChange =>`
`126`		`- targetBranchFiles.some(`
`127`		`- changeRelativeToTargetBranch =>`
`128`		`- changeRelativeToTargetBranch.filename === incrementalChange.filename`
	`124`	`+`
	`125`	`+ // Filter out any file that is changed compared to the incremental changes`
	`126`	`+ const files = targetBranchFiles.filter(targetBranchFile =>`
	`127`	`+ incrementalFiles.some(`
	`128`	`+ incrementalFile => incrementalFile.filename === targetBranchFile.filename`
`129`	`129`	`)`
`130`	`130`	`)`
`131`	`131`