fix(pems_streamlit): use package dependency on pems_data

using a file: dependency on pems_data doesn't work during Docker build time
since we 1) don't copy the pems_data source for the install stage, and 2) we
don't copy the .git directory either -- nor do we want to copy either of these

instead, use a normal package dependency during Docker build
and build and download both local packages and all dependencies
into a 'wheelhouse' for install

update CI to install all 3 packages for tests

Author: thekaveman

.devcontainer/Dockerfile

@@ -55,6 +55,6 @@ RUN pip install .[dev,test]
 RUN pip install --no-cache-dir -r docs/requirements.txt
 
 # install source packages as editable
-# install pems_data separately, and last, to ensure it installs in editable mode
-# and not as a normal package from the dependencies declared in the other packages
-RUN pip install -e ./pems_streamlit -e ./pems_web && pip install -e ./pems_data
+# install pems_data first, to ensure it installs as a
+# package from the dependencies declared in the other packages
+RUN pip install -e ./pems_data -e ./pems_streamlit -e ./pems_web

.github/workflows/tests-pytest.yml

@@ -25,7 +25,7 @@ jobs:
 
       - name: Install Python dependencies
         run: |
-          pip install .[test] ./pems_streamlit ./pems_web
+          pip install .[test] ./pems_data ./pems_streamlit ./pems_web
 
       - name: Run tests
         run: ./tests/pytest/run.sh

pems_streamlit/container/Dockerfile

@@ -7,18 +7,17 @@ ARG PYTHON_VERSION=3.12
 FROM python:${PYTHON_VERSION} AS build_wheel
 WORKDIR /build
 
-# upgrade pip, install build dependencies
-RUN python -m pip install --upgrade pip build setuptools_scm
+# install build tools
+RUN python -m pip install --upgrade pip wheel setuptools_scm
 
 # copy source files
 COPY . .
 RUN git config --global --add safe.directory /build
 
-# Move into directory to run the build
-WORKDIR /build/pems_streamlit
-
-# build package
-RUN python -m build
+# build wheels for local packages AND downloads
+# wheels for all their dependencies from PyPI
+# creating a "wheelhouse"
+RUN pip wheel --wheel-dir /wheels ./pems_data ./pems_streamlit
 
 # multi-stage build
 #
@@ -54,8 +53,11 @@ WORKDIR /$USER/app
 COPY .streamlit .streamlit
 COPY pems_streamlit/container/entrypoint.sh entrypoint.sh
 COPY pems_streamlit/container/run.py run.py
-COPY --from=build_wheel /build/pems_streamlit/dist /wheels
 
-RUN pip install $(find /wheels -name pems_streamlit*.whl)
+# copy the entire, now-complete wheelhouse from the build stage
+COPY --from=build_wheel /wheels /wheels
+
+# install pems_streamlit using only the local wheels directory
+RUN pip install --no-index --find-links=/wheels pems_streamlit
 
 ENTRYPOINT ["./entrypoint.sh"]

pems_streamlit/pyproject.toml

@@ -5,7 +5,9 @@ dynamic = ["version"]
 requires-python = ">=3.12"
 dependencies = [
     "django==5.2.3",
-    "pems_data @ file:./pems_data",
+    # local package reference
+    # a wheel for this package is built during Docker build
+    "pems_data",
     "streamlit==1.45.1",
 ]