Merge pull request #39 from compsoc-edinburgh/add-anonymous-answers

kshxtij · web-flow · commit 6c484708ec95 · 2025-06-03T16:57:11.000+01:00
Anonymous Answers
diff --git a/backend/answers/migrations/0017_answer_is_anonymous.py b/backend/answers/migrations/0017_answer_is_anonymous.py
@@ -0,0 +1,18 @@
+# Generated by Django 4.1.13 on 2025-06-03 12:24
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('answers', '0016_remove_answer_is_legacy_answer_and_more'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='answer',
+            name='is_anonymous',
+            field=models.BooleanField(default=False),
+        ),
+    ]
diff --git a/backend/answers/models.py b/backend/answers/models.py
@@ -137,6 +137,7 @@ class Answer(ExportModelOperationsMixin("answer"), models.Model):
     )
     flagged = models.ManyToManyField("auth.User", related_name="flagged_answer_set")
     long_id = models.CharField(max_length=256, default=generate_long_id, unique=True)
+    is_anonymous = models.BooleanField(default=False)
 
     search_vector = SearchVectorField()
 
diff --git a/backend/answers/section_util.py b/backend/answers/section_util.py
@@ -64,13 +64,31 @@ def get_answer_response(request, answer: Answer, ignore_exam_admin=False):
             }
             for comment in answer.all_comments
         ]
+        
+        # Handle anonymous answers
+        # Check if user is an admin (either exam admin or global admin)
+        is_admin = (ignore_exam_admin is False and exam_admin) or auth_check.has_admin_rights(request)
+        
+        if answer.is_anonymous:
+            if is_admin:
+                # Admins see the real username but with an indication it's anonymous
+                author_id = answer.author.username
+                author_display_name = answer.author.profile.display_username
+            else:
+                # Regular users see "Anonymous"
+                author_id = "anonymous"
+                author_display_name = "Anonymous"
+        else:
+            author_id = answer.author.username
+            author_display_name = answer.author.profile.display_username
+        
         return {
             "oid": answer.id,
             "longId": answer.long_id,
             "upvotes": answer.delta_votes,
             "expertvotes": answer.expert_count,
-            "authorId": answer.author.username,
-            "authorDisplayName": answer.author.profile.display_username,
+            "authorId": author_id,
+            "authorDisplayName": author_display_name,
             "canEdit": answer.author == request.user,
             "isUpvoted": answer.is_upvoted,
             "isDownvoted": answer.is_downvoted,
@@ -83,6 +101,7 @@ def get_answer_response(request, answer: Answer, ignore_exam_admin=False):
             "edittime": answer.edittime,
             "filename": answer.answer_section.exam.filename,
             "sectionId": answer.answer_section.id,
+            "isAnonymous": answer.is_anonymous,
         }
     except AttributeError:
         raise ValueError(
diff --git a/backend/answers/views_answers.py b/backend/answers/views_answers.py
@@ -19,7 +19,7 @@ def get_answer(request, long_id):
         raise Http404()
 
 
-@response.request_post("text")
+@response.request_post("text", "is_anonymous", optional=True)
 @auth_check.require_login
 def set_answer(request, oid):
     section = get_object_or_404(
@@ -38,6 +38,7 @@ def set_answer(request, oid):
         return response.not_allowed()
 
     text = request.POST["text"]
+    is_anonymous = request.POST.get("is_anonymous", "false") != "false"
 
     where = {"answer_section": section, "author": request.user}
 
@@ -49,6 +50,7 @@ def set_answer(request, oid):
             "author": request.user,
             "text": text,
             "edittime": timezone.now(),
+            "is_anonymous": is_anonymous,
         }
         answer, created = Answer.objects.update_or_create(**where, defaults=defaults)
     if created:
diff --git a/backend/answers/views_listings.py b/backend/answers/views_listings.py
@@ -76,7 +76,18 @@ def list_flagged(request):
 @response.request_get()
 @auth_check.require_login
 def get_by_user(request, username, page=-1):
-    sorted_answers = Answer.objects.filter(author__username=username).select_related(
+    # Check if the user is viewing their own profile or is an admin
+    is_own_profile = request.user.username == username
+    is_admin = has_admin_rights(request)
+    
+    # Base query to get answers by the user
+    query = Answer.objects.filter(author__username=username)
+    
+    # If not viewing own profile and not an admin, exclude anonymous answers
+    if not is_own_profile and not is_admin:
+        query = query.filter(is_anonymous=False)
+    
+    sorted_answers = query.select_related(
         *section_util.get_answer_fields_to_preselect()
     )
 
diff --git a/frontend/src/api/hooks.ts b/frontend/src/api/hooks.ts
@@ -271,8 +271,8 @@ export const useRemoveSplit = (oid: string, onSuccess: () => void) => {
   return runRemoveSplit;
 };
 
-const updateAnswer = async (answerId: string, text: string) => {
-  return (await fetchPost(`/api/exam/setanswer/${answerId}/`, { text }))
+const updateAnswer = async (answerId: string, text: string, isAnonymous: boolean = false) => {
+  return (await fetchPost(`/api/exam/setanswer/${answerId}/`, { text, is_anonymous: isAnonymous }))
     .value as AnswerSection;
 };
 const removeAnswer = async (answerId: string) => {
diff --git a/frontend/src/components/answer.tsx b/frontend/src/components/answer.tsx
@@ -9,6 +9,8 @@ import {
   Anchor,
   Box,
   Paper,
+  Switch,
+  Tooltip,
 } from "@mantine/core";
 import { differenceInSeconds } from "date-fns";
 import React, { useCallback, useState } from "react";
@@ -23,6 +25,8 @@ import {
 } from "../api/hooks";
 import { useUser } from "../auth";
 import useConfirm from "../hooks/useConfirm";
+import useToggle from "../hooks/useToggle";
+
 import { Answer, AnswerSection } from "../interfaces";
 import { copy } from "../utils/clipboard";
 import CodeBlock from "./code-block";
@@ -88,27 +92,33 @@ const AnswerComponent: React.FC<Props> = ({
 
   const [draftText, setDraftText] = useState("");
   const [undoStack, setUndoStack] = useState<UndoStack>({ prev: [], next: [] });
+  const [answerIsAnonymous, toggleAnonymity] = useToggle(false);
+  const [hasCommentDraft, setHasCommentDraft] = useState(false);
+
   const startEdit = useCallback(() => {
     setDraftText(answer?.text ?? "");
+    if (answer?.isAnonymous) {
+      toggleAnonymity(true);
+    }
     setEditing(true);
-  }, [answer]);
+  }, [answer, toggleAnonymity]);
   const onCancel = useCallback(() => {
     setEditing(false);
     if (answer === undefined && onDelete) onDelete();
   }, [onDelete, answer]);
   const save = useCallback(() => {
-    if (section) update(section.oid, draftText);
-  }, [section, draftText, update]);
+    if (section) update(section.oid, draftText, answerIsAnonymous);
+  }, [section, draftText, update, answerIsAnonymous]);
   const remove = useCallback(() => {
     if (answer) confirm("Remove answer?", () => removeAnswer(answer.oid));
   }, [confirm, removeAnswer, answer]);
-  const [hasCommentDraft, setHasCommentDraft] = useState(false);
 
   const flaggedLoading = setFlaggedLoading || resetFlaggedLoading;
   const canEdit = section && onSectionChanged && (answer?.canEdit || false);
   const canRemove =
     section && onSectionChanged && (isAdmin || answer?.canEdit || false);
   const { username } = useUser()!;
+
   return (
     <>
       {modals}
@@ -131,18 +141,44 @@ const AnswerComponent: React.FC<Props> = ({
                 </Text>
               </Link>
             )}
-            <Anchor
-              component={Link}
-              to={`/user/${answer?.authorId ?? username}`}
-              className={displayNameClasses.shrinkableDisplayName}
-            >
-              <Text fw={700} component="span">
-                {answer?.authorDisplayName ?? "(Draft)"}
-              </Text>
-              <Text ml="0.3em" c="dimmed" component="span">
-                @{answer?.authorId ?? username}
-              </Text>
-            </Anchor>
+            {answer?.isAnonymous ? (
+              isAdmin ? (
+                // Admin view of anonymous posts - clickable
+                <Anchor
+                  component={Link}
+                  to={`/user/${answer.authorId}`}
+                  className={displayNameClasses.shrinkableDisplayName}
+                >
+                  <Text fw={700} component="span">
+                    {answer.authorDisplayName} <Text c="dimmed" component="span">(Posted anonymously)</Text>
+                  </Text>
+                </Anchor>
+              ) : answer?.canEdit ? (
+                // User's own anonymous post
+                <Text fw={700} component="span">
+                  {answer.authorDisplayName} <Text c="dimmed" component="span">(Your anonymous post)</Text>
+                </Text>
+              ) : (
+                // Regular user view of anonymous posts - not clickable
+                <Text fw={700} component="span">
+                  {answer.authorDisplayName}
+                </Text>
+              )
+            ) : (
+              // Regular non-anonymous posts
+              <Anchor
+                component={Link}
+                to={`/user/${answer?.authorId ?? username}`}
+                className={displayNameClasses.shrinkableDisplayName}
+              >
+                <Text fw={700} component="span">
+                  {answer?.authorDisplayName ?? "(Draft)"}
+                </Text>
+                <Text ml="0.3em" c="dimmed" component="span">
+                  @{answer?.authorId ?? username}
+                </Text>
+              </Anchor>
+            )}
             <Text c="dimmed" mx={6} component="span">
               ·
             </Text>
@@ -297,6 +333,26 @@ const AnswerComponent: React.FC<Props> = ({
           </Card.Section>
         )}
         <Group justify="right">
+          {(answer === undefined || editing) && (
+            <Tooltip
+              label="Your answer will appear as 'Anonymous' to regular users, but admins will still be able to see your username. Anonymous answers won't appear on your public profile."
+              multiline
+              maw={300}
+              withArrow
+              withinPortal
+            >
+              <div>
+                <Switch
+                  label={answer?.isAnonymous ? "Post Anonymously (currently anonymous)" : "Post Anonymously"}
+                  onChange={() => {
+                    console.log("Toggling anonymity");
+                    toggleAnonymity();
+                  }}
+                  checked={answerIsAnonymous}
+                />
+              </div>
+            </Tooltip>
+          )}
           {(answer === undefined || editing) && (
             <Button
               size="sm"
@@ -322,69 +378,69 @@ const AnswerComponent: React.FC<Props> = ({
           {onSectionChanged && !editing && (
             <Flex align="center">
               {answer !== undefined && (
-              <Button.Group>
-                <Button
-                  size="sm"
-                  onClick={() => setHasCommentDraft(true)}
-                  leftSection={<IconPlus />}
-                  disabled={hasCommentDraft}
-                  color="dark"
-                >
-                  Add Comment
-                </Button>
-                <Menu withinPortal>
-                  <Menu.Target>
-                    <Button leftSection={<IconDots />} color="dark">More</Button>
-                  </Menu.Target>
-                  <Menu.Dropdown>
-                    {answer.flagged === 0 && (
-                      <Menu.Item
-                        leftSection={<IconFlag />}
-                        onClick={() => setFlagged(answer.oid, true)}
-                      >
-                        Flag as Inappropriate
-                      </Menu.Item>
-                    )}
-                    <Menu.Item
-                      leftSection={<IconLink />}
-                      onClick={() =>
-                        copy(
-                          `${document.location.origin}/exams/${answer.filename}#${answer.longId}`,
-                        )
-                      }
-                    >
-                      Copy Permalink
-                    </Menu.Item>
-                    {isAdmin && answer.flagged > 0 && (
+                <Button.Group>
+                  <Button
+                    size="sm"
+                    onClick={() => setHasCommentDraft(true)}
+                    leftSection={<IconPlus />}
+                    disabled={hasCommentDraft}
+                    color="dark"
+                  >
+                    Add Comment
+                  </Button>
+                  <Menu withinPortal>
+                    <Menu.Target>
+                      <Button leftSection={<IconDots />} color="dark">More</Button>
+                    </Menu.Target>
+                    <Menu.Dropdown>
+                      {answer.flagged === 0 && (
+                        <Menu.Item
+                          leftSection={<IconFlag />}
+                          onClick={() => setFlagged(answer.oid, true)}
+                        >
+                          Flag as Inappropriate
+                        </Menu.Item>
+                      )}
                       <Menu.Item
-                        leftSection={<IconFlag />}
-                        onClick={() => resetFlagged(answer.oid)}
+                        leftSection={<IconLink />}
+                        onClick={() =>
+                          copy(
+                            `${document.location.origin}/exams/${answer.filename}#${answer.longId}`,
+                          )
+                        }
                       >
-                        Remove all inappropriate flags
+                        Copy Permalink
                       </Menu.Item>
-                    )}
-                    {!editing && canEdit && (
+                      {isAdmin && answer.flagged > 0 && (
+                        <Menu.Item
+                          leftSection={<IconFlag />}
+                          onClick={() => resetFlagged(answer.oid)}
+                        >
+                          Remove all inappropriate flags
+                        </Menu.Item>
+                      )}
+                      {!editing && canEdit && (
+                        <Menu.Item
+                          leftSection={<IconEdit />}
+                          onClick={startEdit}
+                        >
+                          Edit
+                        </Menu.Item>
+                      )}
+                      {answer && canRemove && (
+                        <Menu.Item leftSection={<IconTrash />} onClick={remove}>
+                          Delete
+                        </Menu.Item>
+                      )}
                       <Menu.Item
-                        leftSection={<IconEdit />}
-                        onClick={startEdit}
+                        leftSection={<IconCode />}
+                        onClick={toggleViewSource}
                       >
-                        Edit
-                      </Menu.Item>
-                    )}
-                    {answer && canRemove && (
-                      <Menu.Item leftSection={<IconTrash />} onClick={remove}>
-                        Delete
+                        Toggle Source Code Mode
                       </Menu.Item>
-                    )}
-                    <Menu.Item
-                      leftSection={<IconCode />}
-                      onClick={toggleViewSource}
-                    >
-                      Toggle Source Code Mode
-                    </Menu.Item>
-                  </Menu.Dropdown>
-                </Menu>
-            </Button.Group>
+                    </Menu.Dropdown>
+                  </Menu>
+                </Button.Group>
               )}
             </Flex>
           )}
@@ -405,4 +461,4 @@ const AnswerComponent: React.FC<Props> = ({
   );
 };
 
-export default AnswerComponent;
+export default AnswerComponent;
diff --git a/frontend/src/components/user-answers.tsx b/frontend/src/components/user-answers.tsx
diff --git a/frontend/src/interfaces.ts b/frontend/src/interfaces.ts

Original file line number	Diff line number	Diff line change
`@@ -137,6 +137,7 @@ class Answer(ExportModelOperationsMixin("answer"), models.Model):`
`137`	`137`	`)`
`138`	`138`	`flagged = models.ManyToManyField("auth.User", related_name="flagged_answer_set")`
`139`	`139`	`long_id = models.CharField(max_length=256, default=generate_long_id, unique=True)`
	`140`	`+ is_anonymous = models.BooleanField(default=False)`
`140`	`141`
`141`	`142`	`search_vector = SearchVectorField()`
`142`	`143`