-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
Good First IssueThis issue would be a good issue for a first time contributor to undertake.This issue would be a good issue for a first time contributor to undertake.triagedIssue has been triagedIssue has been triaged
Description
Fix commented out test case for the healtcheck bindings
podman/pkg/bindings/test/containers_test.go
Lines 332 to 358 in 0215832
// TODO for the life of me, i cannot get this to work. maybe another set | |
// of eyes will | |
// successful healthcheck | |
// status := define.HealthCheckHealthy | |
// for i:=0; i < 10; i++ { | |
// result, err := containers.RunHealthCheck(connText, "hc") | |
// Expect(err).To(BeNil()) | |
// if result.Status != define.HealthCheckHealthy { | |
// fmt.Println("Healthcheck container still starting, retrying in 1 second") | |
// time.Sleep(1 * time.Second) | |
// continue | |
// } | |
// status = result.Status | |
// break | |
// } | |
// Expect(status).To(Equal(define.HealthCheckHealthy)) | |
// TODO enable this when wait is working | |
// healthcheck on a stopped container should be a 409 | |
// err = containers.Stop(connText, "hc", nil) | |
// Expect(err).To(BeNil()) | |
// _, err = containers.Wait(connText, "hc") | |
// Expect(err).To(BeNil()) | |
// _, err = containers.RunHealthCheck(connText, "hc") | |
// code, _ = bindings.CheckResponseCode(err) | |
// Expect(code).To(BeNumerically("==", http.StatusConflict)) |
Metadata
Metadata
Labels
Good First IssueThis issue would be a good issue for a first time contributor to undertake.This issue would be a good issue for a first time contributor to undertake.triagedIssue has been triagedIssue has been triaged