Skip to content

Commit 54be5fa

Browse files
committed
refactor: change renderer.addClass to HostBinding
1 parent 73a4290 commit 54be5fa

9 files changed

+34
-54
lines changed

projects/coreui/angular/src/lib/aside/app-aside.component.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {Component, ElementRef, Input, OnInit, OnDestroy, Inject, Renderer2} from '@angular/core';
1+
import {Component, Input, OnInit, OnDestroy, Inject, Renderer2, HostBinding} from '@angular/core';
22
import {DOCUMENT} from '@angular/common';
33

44
import { asideMenuCssClasses } from '../shared';
@@ -14,13 +14,12 @@ export class AppAsideComponent implements OnInit, OnDestroy {
1414

1515
private readonly fixedClass = 'aside-menu-fixed';
1616

17+
@HostBinding('class.aside-menu') _aside = true;
18+
1719
constructor(
1820
@Inject(DOCUMENT) private document: any,
1921
private renderer: Renderer2,
20-
private hostElement: ElementRef
21-
) {
22-
renderer.addClass(hostElement.nativeElement, 'aside-menu');
23-
}
22+
) { }
2423

2524
ngOnInit(): void {
2625
this.isFixed(this.fixed);

projects/coreui/angular/src/lib/footer/app-footer.component.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {Component, ElementRef, Inject, Input, OnDestroy, OnInit, Renderer2} from '@angular/core';
1+
import {Component, HostBinding, Inject, Input, OnDestroy, OnInit, Renderer2} from '@angular/core';
22
import {DOCUMENT} from '@angular/common';
33

44
@Component({
@@ -10,13 +10,12 @@ export class AppFooterComponent implements OnInit, OnDestroy {
1010

1111
private readonly fixedClass = 'footer-fixed';
1212

13+
@HostBinding('class.app-footer') _footer = true;
14+
1315
constructor(
1416
@Inject(DOCUMENT) private document: any,
1517
private renderer: Renderer2,
16-
private hostElement: ElementRef
17-
) {
18-
renderer.addClass(hostElement.nativeElement, 'app-footer');
19-
}
18+
) { }
2019

2120
ngOnInit(): void {
2221
this.isFixed(this.fixed);

projects/coreui/angular/src/lib/header/app-header.component.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {Component, ElementRef, Input, OnInit, OnDestroy, Inject, Renderer2} from '@angular/core';
1+
import {Component, Input, OnInit, OnDestroy, Inject, Renderer2, HostBinding} from '@angular/core';
22
import { DOCUMENT } from '@angular/common';
33

44
@Component({
@@ -23,6 +23,10 @@ export class AppHeaderComponent implements OnInit, OnDestroy {
2323
@Input() mobileAsideMenuToggler: boolean;
2424

2525
private readonly fixedClass = 'header-fixed';
26+
27+
@HostBinding('class.app-header') _header = true;
28+
@HostBinding('class.navbar') _navbar = true;
29+
2630
navbarBrandImg: boolean;
2731

2832
private readonly breakpoints = ['xl', 'lg', 'md', 'sm', 'xs'];
@@ -34,11 +38,7 @@ export class AppHeaderComponent implements OnInit, OnDestroy {
3438
constructor(
3539
@Inject(DOCUMENT) private document: any,
3640
private renderer: Renderer2,
37-
private hostElement: ElementRef
38-
) {
39-
renderer.addClass(hostElement.nativeElement, 'app-header');
40-
renderer.addClass(hostElement.nativeElement, 'navbar');
41-
}
41+
) { }
4242

4343
ngOnInit(): void {
4444
this.isFixed(this.fixed);
Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
1-
import {Component, ElementRef, OnInit, Renderer2} from '@angular/core';
1+
import {Component, HostBinding} from '@angular/core';
22

33
@Component({
44
selector: 'app-sidebar-footer, cui-sidebar-footer',
55
template: `<ng-content></ng-content>`
66
})
7-
export class AppSidebarFooterComponent implements OnInit {
7+
export class AppSidebarFooterComponent {
88

9-
constructor(
10-
private renderer: Renderer2,
11-
private hostElement: ElementRef
12-
) {
13-
renderer.addClass(hostElement.nativeElement, 'app-sidebar-footer');
14-
}
9+
@HostBinding('class.sidebar-footer') _sidebarFooter = true;
1510

16-
ngOnInit() { }
11+
constructor() { }
1712
}
Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
1-
import {Component, ElementRef, OnInit, Renderer2} from '@angular/core';
1+
import {Component, HostBinding} from '@angular/core';
22

33
@Component({
44
selector: 'app-sidebar-form, cui-sidebar-form',
55
template: `<ng-content></ng-content>`
66
})
7-
export class AppSidebarFormComponent implements OnInit {
7+
export class AppSidebarFormComponent {
88

9-
constructor(
10-
private renderer: Renderer2,
11-
private hostElement: ElementRef
12-
) {
13-
renderer.addClass(hostElement.nativeElement, 'sidebar-form');
14-
}
15-
ngOnInit() { }
9+
@HostBinding('class.sidebar-form') _sidebarForm = true;
10+
11+
constructor() { }
1612
}
Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
1-
import {Component, ElementRef, OnInit, Renderer2} from '@angular/core';
1+
import {Component, HostBinding} from '@angular/core';
22

33
@Component({
44
selector: 'app-sidebar-header, cui-sidebar-header',
55
template: `<ng-content></ng-content>`
66
})
7-
export class AppSidebarHeaderComponent implements OnInit {
7+
export class AppSidebarHeaderComponent {
88

9-
constructor(
10-
private renderer: Renderer2,
11-
private hostElement: ElementRef
12-
) {
13-
renderer.addClass(hostElement.nativeElement, 'sidebar-header');
14-
}
9+
@HostBinding('class.sidebar-header') _sidebarHeader = true;
1510

16-
ngOnInit() { }
11+
constructor() { }
1712
}

projects/coreui/angular/src/lib/sidebar/app-sidebar-minimizer.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, HostBinding, HostListener, Optional } from '@angular/core';
1+
import {Component, HostBinding, HostListener, Input} from '@angular/core';
22

33
import { AppSidebarService } from './app-sidebar.service';
44

@@ -8,7 +8,7 @@ import { AppSidebarService } from './app-sidebar.service';
88
})
99
export class AppSidebarMinimizerComponent {
1010

11-
@HostBinding('attr.role') role = 'button';
11+
@HostBinding('attr.role') @Input() role = 'button';
1212
@HostBinding('class.sidebar-minimizer') _minimizer = true;
1313

1414
@HostListener('click', ['$event'])

projects/coreui/angular/src/lib/sidebar/app-sidebar-nav.component.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, ElementRef, HostBinding, Input, OnChanges, Renderer2, SimpleChanges } from '@angular/core';
1+
import { Component, HostBinding, Input, OnChanges, SimpleChanges } from '@angular/core';
22
import { Router } from '@angular/router';
33

44
import { INavData } from './app-sidebar-nav';
@@ -10,17 +10,14 @@ import { INavData } from './app-sidebar-nav';
1010
export class AppSidebarNavComponent implements OnChanges {
1111
@Input() navItems: INavData[] = [];
1212

13-
@HostBinding('attr.role') role = 'nav';
13+
@HostBinding('class.sidebar-nav') _sidebarBav = true;
14+
@HostBinding('attr.role') @Input() role = 'nav';
1415

1516
public navItemsArray: INavData[] = [];
1617

1718
constructor(
1819
public router: Router,
19-
private renderer: Renderer2,
20-
private hostElement: ElementRef
21-
) {
22-
renderer.addClass(hostElement.nativeElement, 'sidebar-nav');
23-
}
20+
) { }
2421

2522
public ngOnChanges(changes: SimpleChanges): void {
2623
this.navItemsArray = Array.isArray(this.navItems) ? this.navItems.slice() : [];

projects/coreui/angular/src/lib/sidebar/app-sidebar.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@ export class AppSidebarComponent implements OnInit, OnDestroy {
4545
@Inject(DOCUMENT) private document: any,
4646
private renderer: Renderer2,
4747
private sidebarService: AppSidebarService
48-
) {
49-
}
48+
) { }
5049

5150
ngOnInit(): void {
5251
this.displayBreakpoint(this.display);

0 commit comments

Comments
 (0)