chore: clean-up

mrholek · mrholek · commit 8fba7807ccd5 · 2023-09-20T09:11:04.000+02:00
diff --git a/packages/coreui-react/src/components/button/CButton.tsx b/packages/coreui-react/src/components/button/CButton.tsx
@@ -77,7 +77,7 @@ export const CButton = forwardRef<HTMLButtonElement | HTMLAnchorElement, CButton
     return (
       <CLink
         component={rest.href ? 'a' : component}
-        type={type}
+        {...(!rest.href && { type: type })}
         className={classNames(
           'btn',
           variant ? `btn-${variant}-${color}` : `btn-${color}`,
diff --git a/packages/coreui-react/src/components/dropdown/CDropdownToggle.tsx b/packages/coreui-react/src/components/dropdown/CDropdownToggle.tsx
@@ -80,7 +80,7 @@ export const CDropdownToggle: FC<CDropdownToggleProps> = ({
     }
 
     return (
-      <CButton type="button" {...togglerProps} tabIndex={0} {...rest} ref={dropdownToggleRef}>
+      <CButton {...togglerProps} tabIndex={0} {...rest} ref={dropdownToggleRef}>
         {children}
         {split && <span className="visually-hidden">Toggle Dropdown</span>}
       </CButton>

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ export const CDropdownToggle: FC<CDropdownToggleProps> = ({`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`return (`
`83`		`- <CButton type="button" {...togglerProps} tabIndex={0} {...rest} ref={dropdownToggleRef}>`
	`83`	`+ <CButton {...togglerProps} tabIndex={0} {...rest} ref={dropdownToggleRef}>`
`84`	`84`	`{children}`
`85`	`85`	`{split && <span className="visually-hidden">Toggle Dropdown</span>}`
`86`	`86`	`</CButton>`