Skip to content

Commit ce58be8

Browse files
committed
MB-41321: 3/4 removeDeletedDoc redundant collection item count adjustment
During rollback's removeDeletedDoc function we read lock the manifest and decrement the collection's item count, yet at the end of rollback we throw away the manifest and create a new one using the rollback point, making the decrement (and read-locking) redundant. Change-Id: I1803d516c66841fd92ccefc843a62db9e17b2fe4 Reviewed-on: http://review.couchbase.org/c/kv_engine/+/137408 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Dave Rigby <daver@couchbase.com>
1 parent 250d307 commit ce58be8

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

engines/ep/src/ep_bucket.cc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1564,9 +1564,6 @@ class EPDiskRollbackCB : public RollbackCB {
15641564
// Irrespective of if the in-memory delete succeeded; the document
15651565
// doesn't exist on disk; so decrement the item count.
15661566
vb.decrNumTotalItems();
1567-
// @todo: investigate if this is needed. Once rollback is done we
1568-
// reset all collections stats from the rollback point
1569-
vb.getManifest().lock(item.getKey()).decrementItemCount();
15701567
}
15711568
}
15721569

0 commit comments

Comments
 (0)