Skip to content

Commit fe6f1c1

Browse files
committed
Slightly improve HttpsTestServerLayer
- Send Content-Length header based on the encoded response body - Additionally send "Connection: close" header - Reduce sleep time after starting the server thread
1 parent e5e74cd commit fe6f1c1

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/crate/client/tests.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ class Location(Base):
213213
test.globs['CrateDialect'] = CrateDialect
214214

215215

216-
class HttpsTestServerLayer(object):
216+
class HttpsTestServerLayer:
217217
PORT = 65534
218218
HOST = "localhost"
219219
CERT_FILE = os.path.abspath(os.path.join(os.path.dirname(__file__),
@@ -238,11 +238,12 @@ class HttpsHandler(BaseHTTPRequestHandler):
238238

239239
def do_GET(self):
240240
self.send_response(200)
241-
self.send_header("Content-Length", len(self.payload))
241+
payload = self.payload.encode('UTF-8')
242+
self.send_header("Content-Length", len(payload))
242243
self.send_header("Content-Type", "application/json; charset=UTF-8")
244+
self.send_header("Connection", "close")
243245
self.end_headers()
244-
self.wfile.write(self.payload.encode('UTF-8'))
245-
return
246+
self.wfile.write(payload)
246247

247248
def __init__(self):
248249
self.server = self.HttpsServer(
@@ -254,7 +255,7 @@ def setUp(self):
254255
thread = threading.Thread(target=self.serve_forever)
255256
thread.daemon = True # quit interpreter when only thread exists
256257
thread.start()
257-
time.sleep(1)
258+
time.sleep(0.5)
258259

259260
def serve_forever(self):
260261
print("listening on", self.HOST, self.PORT)

0 commit comments

Comments
 (0)