Skip to content

Commit 4fc5d8c

Browse files
authored
update a call to the package:shelf_web_socket webSocketHandler() function (#2659)
* update a call to the package:shelf_web_socket webSocketHandler() function * update pubspec version
1 parent cb68ac3 commit 4fc5d8c

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

dwds/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 24.4.2-wip
2+
3+
- Update a call to the `package:shelf_web_socket` `webSocketHandler()` function.
4+
15
## 24.4.1
26

37
- Implemented a WebSocket-based communication protocol that provides essential developer tooling (hot reload, service extensions) when Chrome debugger access is unavailable. - [#2605](https://github.com/dart-lang/webdev/issues/2605)

dwds/lib/src/services/debug_service.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,11 +436,11 @@ class WebSocketDebugService implements DebugService {
436436
}
437437

438438
/// Creates the WebSocket handler for incoming connections.
439-
static dynamic _createWebSocketHandler(
439+
static Handler _createWebSocketHandler(
440440
ServiceExtensionRegistry serviceExtensionRegistry,
441441
WebSocketProxyService webSocketProxyService,
442442
) {
443-
return webSocketHandler((WebSocketChannel webSocket) {
443+
return webSocketHandler((WebSocketChannel webSocket, String? subprotocol) {
444444
final responseController = StreamController<Map<String, Object?>>();
445445
webSocket.sink.addStream(responseController.stream.map(jsonEncode));
446446

dwds/lib/src/version.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: dwds
22
# Every time this changes you need to run `dart run build_runner build`.
3-
version: 24.4.1
3+
version: 24.4.2-wip
44

55
description: >-
66
A service that proxies between the Chrome debug protocol and the Dart VM
@@ -29,7 +29,7 @@ dependencies:
2929
shelf_packages_handler: ^3.0.0
3030
shelf_proxy: ^1.0.4
3131
shelf_static: ^1.1.0
32-
shelf_web_socket: '>=1.0.0 <3.0.0'
32+
shelf_web_socket: '>=2.0.0 <4.0.0'
3333
source_maps: ^0.10.10
3434
stack_trace: ^1.10.0
3535
sse: ^4.1.2

0 commit comments

Comments
 (0)