vector search: add reranker parameter #216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanzeyi
force-pushed
the
push-lmukwtlspows
branch
from
fd865e4 to
972b9fc
Compare
annzhang-db
reviewed
Nov 11, 2025
| filters=filter, | ||
| num_results=k, | ||
| query_type=query_type, | ||
| reranker=self._reranker, |
Contributor
There was a problem hiding this comment.
Since we previously recommended that people pass reranker through kwargs, can we make sure that adding this won't accidentally break this function (duplicate keyword arg) for those who are passing reranker that way?
annzhang-db
reviewed
Nov 11, 2025
| filters=filter, | ||
| num_results=fetch_k, | ||
| query_type=query_type, | ||
| reranker=self._reranker, |
fanzeyi
force-pushed
the
push-lmukwtlspows
branch
from
972b9fc to
040644b
Compare
Member
Author
|
@annzhang-db updated :) |
Test Plan: ``` $ uv run ipython ... In [1]: from databricks_langchain import VectorSearchRetrieverTool, ChatDatabricks In [2]: help(VectorSearchRetrieverTool) class VectorSearchRetrieverTool(langchain_core.tools.base.BaseTool, databricks_ai_bridge.vector_search_retriever_tool.VectorSearchRetrieverToolMixin) | VectorSearchRetrieverTool( | *, ... | reranker: databricks.vector_search.reranker.DatabricksReranker | None = None, ``` `reranker` now appears in the parameter list. Tests: ``` $ uv run pytest integrations/langchain/tests/unit_tests ... =============================================== 4 failed, 194 passed, 2 skipped, 588 warnings in 2.27s =============================================== # Pre-existing issues $ uv run pytest integrations/llamaindex/tests/unit_tests ... ========================================================== 112 passed, 88 warnings in 1.60s ========================================================== $ uv run pytest integrations/openai/tests/unit_tests ... ========================================================== 50 passed, 923 warnings in 1.76s ========================================================== ```
fanzeyi
force-pushed
the
push-lmukwtlspows
branch
from
040644b to
3591df7
Compare
annzhang-db
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reranker parameter to various vector search tools in our integration libraries to make it more obvious this is supported.
Test Plan:
rerankernow appears in the parameter list.Tests: