fix: Do not set UniForm properties on managed iceberg #1256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericj-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
ericj-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
ericj-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
benc-db
reviewed
Nov 11, 2025
| # processors can use it. This is needed by TblPropertiesProcessor to determine | ||
| # if we should add UniForm properties | ||
| if "_databricks_use_managed_iceberg" not in model.config.extra: | ||
| model.config.extra["_databricks_use_managed_iceberg"] = bool( |
Collaborator
There was a problem hiding this comment.
this should be a constant if you're going to use this key multiple places. I also wonder if we should just store this in GlobalState since it will be true for the entire session, and then we won't need to stuff it on the model config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Description
There is a bug in
TblPropertiesProcessorthat is assuming that all tables with iceberg format need UniForm properties to be set. When managed iceberg behavior flag is enabled, this causes the materialization to failThe fix is to only apply these properties when working with a UniForm table. Unfortunately, we cannot use the
file_formatto distinguish because we do not actually require the user to setfile_formattoparquetfor managed iceberg. We infer it in the adapter based on thetable_formatand behavior flag. To work around this fact, I am settingmodel.config.extra["_databricks_use_managed_iceberg"]to pass the information to the config processorChecklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.