refactor: migrate ConfigModel to Pydantic v2 and consolidate config

- Migrate ConfigModel from Pydantic v1 style (class Config) to v2 style (model_config = ConfigDict)
- Replace 35 instances of manual 'model_config = {"extra": "forbid"}' with ConfigModel inheritance across 9 files
- Simplify Filter union in search_filters.py by removing TYPE_CHECKING conditional
- Fix redshift.py to use parse_obj_allow_extras() instead of direct Config.extra manipulation

This eliminates code duplication and centralizes Pydantic configuration policy.

Author: sgomezvillamor

metadata-ingestion/src/datahub/api/entities/assertion/assertion.py

@@ -1,15 +1,14 @@
 from abc import abstractmethod
 from typing import Optional
 
-from pydantic import BaseModel, Field
+from pydantic import Field
 
 from datahub.api.entities.assertion.assertion_trigger import AssertionTrigger
+from datahub.configuration.common import ConfigModel
 from datahub.metadata.com.linkedin.pegasus2avro.assertion import AssertionInfo
 
 
-class BaseAssertionProtocol(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class BaseAssertionProtocol(ConfigModel):
     @abstractmethod
     def get_id(self) -> str:
         pass
@@ -27,9 +26,7 @@ def get_assertion_trigger(
         pass
 
 
-class BaseAssertion(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class BaseAssertion(ConfigModel):
     id_raw: Optional[str] = Field(
         default=None,
         description="The raw id of the assertion."

metadata-ingestion/src/datahub/api/entities/assertion/assertion_config_spec.py

@@ -1,13 +1,14 @@
 from typing import List, Optional
 
-from pydantic import BaseModel, Field
+from pydantic import Field
 from ruamel.yaml import YAML
 from typing_extensions import Literal
 
 from datahub.api.entities.assertion.datahub_assertion import DataHubAssertion
+from datahub.configuration.common import ConfigModel
 
 
-class AssertionsConfigSpec(BaseModel):
+class AssertionsConfigSpec(ConfigModel):
     """
     Declarative configuration specification for datahub assertions.
 
@@ -18,8 +19,6 @@ class AssertionsConfigSpec(BaseModel):
     In future, this would invoke datahub GraphQL API to upsert assertions.
     """
 
-    model_config = {"extra": "forbid"}
-
     version: Literal[1]
 
     id: Optional[str] = Field(

metadata-ingestion/src/datahub/api/entities/assertion/assertion_operator.py

@@ -1,9 +1,9 @@
 import json
 from typing import List, Optional, Union
 
-from pydantic import BaseModel
 from typing_extensions import Literal, Protocol
 
+from datahub.configuration.common import ConfigModel
 from datahub.metadata.schema_classes import (
     AssertionStdOperatorClass,
     AssertionStdParameterClass,
@@ -61,9 +61,7 @@ def _generate_assertion_std_parameters(
     )
 
 
-class EqualToOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class EqualToOperator(ConfigModel):
     type: Literal["equal_to"]
     value: Union[str, int, float]
 
@@ -76,8 +74,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class NotEqualToOperator(BaseModel):
-    model_config = {"extra": "forbid"}
+class NotEqualToOperator(ConfigModel):
     type: Literal["not_equal_to"]
     value: Union[str, int, float]
 
@@ -90,9 +87,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class BetweenOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class BetweenOperator(ConfigModel):
     type: Literal["between"]
     min: Union[int, float]
     max: Union[int, float]
@@ -108,9 +103,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         )
 
 
-class LessThanOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class LessThanOperator(ConfigModel):
     type: Literal["less_than"]
     value: Union[int, float]
 
@@ -123,9 +116,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class GreaterThanOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class GreaterThanOperator(ConfigModel):
     type: Literal["greater_than"]
     value: Union[int, float]
 
@@ -138,9 +129,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class LessThanOrEqualToOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class LessThanOrEqualToOperator(ConfigModel):
     type: Literal["less_than_or_equal_to"]
     value: Union[int, float]
 
@@ -153,9 +142,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class GreaterThanOrEqualToOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class GreaterThanOrEqualToOperator(ConfigModel):
     type: Literal["greater_than_or_equal_to"]
     value: Union[int, float]
 
@@ -168,9 +155,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class InOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class InOperator(ConfigModel):
     type: Literal["in"]
     value: List[Union[str, float, int]]
 
@@ -183,9 +168,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class NotInOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class NotInOperator(ConfigModel):
     type: Literal["not_in"]
     value: List[Union[str, float, int]]
 
@@ -198,9 +181,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class IsNullOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class IsNullOperator(ConfigModel):
     type: Literal["is_null"]
 
     operator: str = AssertionStdOperatorClass.NULL
@@ -212,9 +193,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters()
 
 
-class NotNullOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class NotNullOperator(ConfigModel):
     type: Literal["is_not_null"]
 
     operator: str = AssertionStdOperatorClass.NOT_NULL
@@ -226,9 +205,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters()
 
 
-class IsTrueOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class IsTrueOperator(ConfigModel):
     type: Literal["is_true"]
 
     operator: str = AssertionStdOperatorClass.IS_TRUE
@@ -240,9 +217,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters()
 
 
-class IsFalseOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class IsFalseOperator(ConfigModel):
     type: Literal["is_false"]
 
     operator: str = AssertionStdOperatorClass.IS_FALSE
@@ -254,9 +229,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters()
 
 
-class ContainsOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class ContainsOperator(ConfigModel):
     type: Literal["contains"]
     value: str
 
@@ -269,9 +242,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class EndsWithOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class EndsWithOperator(ConfigModel):
     type: Literal["ends_with"]
     value: str
 
@@ -284,9 +255,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class StartsWithOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class StartsWithOperator(ConfigModel):
     type: Literal["starts_with"]
     value: str
 
@@ -299,9 +268,7 @@ def generate_parameters(self) -> AssertionStdParametersClass:
         return _generate_assertion_std_parameters(value=self.value)
 
 
-class MatchesRegexOperator(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class MatchesRegexOperator(ConfigModel):
     type: Literal["matches_regex"]
     value: str
 

metadata-ingestion/src/datahub/api/entities/assertion/assertion_trigger.py

@@ -2,13 +2,13 @@
 from typing import Union
 
 import humanfriendly
-from pydantic import BaseModel, Field, RootModel, field_validator
+from pydantic import Field, RootModel, field_validator
 from typing_extensions import Literal
 
+from datahub.configuration.common import ConfigModel
 
-class CronTrigger(BaseModel):
-    model_config = {"extra": "forbid"}
 
+class CronTrigger(ConfigModel):
     type: Literal["cron"]
     cron: str = Field(
         description="The cron expression to use. See https://crontab.guru/ for help."
@@ -19,9 +19,7 @@ class CronTrigger(BaseModel):
     )
 
 
-class IntervalTrigger(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class IntervalTrigger(ConfigModel):
     type: Literal["interval"]
     interval: timedelta
 
@@ -34,15 +32,11 @@ def lookback_interval_to_timedelta(cls, v):
         raise ValueError("Invalid value.")
 
 
-class EntityChangeTrigger(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class EntityChangeTrigger(ConfigModel):
     type: Literal["on_table_change"]
 
 
-class ManualTrigger(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class ManualTrigger(ConfigModel):
     type: Literal["manual"]
 
 

metadata-ingestion/src/datahub/api/entities/assertion/field_assertion.py

@@ -1,7 +1,7 @@
 from enum import Enum
 from typing import Optional, Union
 
-from pydantic import BaseModel, Field
+from pydantic import Field
 from typing_extensions import Literal
 
 from datahub.api.entities.assertion.assertion import (
@@ -11,6 +11,7 @@
 from datahub.api.entities.assertion.assertion_trigger import AssertionTrigger
 from datahub.api.entities.assertion.field_metric import FieldMetric
 from datahub.api.entities.assertion.filter import DatasetFilter
+from datahub.configuration.common import ConfigModel
 from datahub.emitter.mce_builder import datahub_guid
 from datahub.metadata.com.linkedin.pegasus2avro.assertion import (
     AssertionInfo,
@@ -29,9 +30,7 @@
 )
 
 
-class FieldValuesFailThreshold(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class FieldValuesFailThreshold(ConfigModel):
     type: Literal["count", "percentage"] = Field(default="count")
     value: int = Field(default=0)
 

metadata-ingestion/src/datahub/api/entities/assertion/filter.py

@@ -1,10 +1,9 @@
-from pydantic import BaseModel
 from typing_extensions import Literal
 
+from datahub.configuration.common import ConfigModel
 
-class SqlFilter(BaseModel):
-    model_config = {"extra": "forbid"}
 
+class SqlFilter(ConfigModel):
     type: Literal["sql"]
     sql: str
 

metadata-ingestion/src/datahub/api/entities/datacontract/assertion.py

@@ -1,9 +1,7 @@
 from typing import Optional
 
-from pydantic import BaseModel
+from datahub.configuration.common import ConfigModel
 
 
-class BaseAssertion(BaseModel):
-    model_config = {"extra": "forbid"}
-
+class BaseAssertion(ConfigModel):
     description: Optional[str] = None