Skip to content

Commit b1383de

Browse files
committed
Remove unneded code
1 parent dcef746 commit b1383de

File tree

4 files changed

+54
-95
lines changed

4 files changed

+54
-95
lines changed

metadata-ingestion/src/datahub/ingestion/source/kafka_connect/common.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -387,26 +387,6 @@ class ConnectorManifest:
387387
lineages: List[KafkaConnectLineage] = field(default_factory=list)
388388
topic_names: List[str] = field(default_factory=list)
389389

390-
def extract_lineages(
391-
self, config: "KafkaConnectSourceConfig", report: "KafkaConnectSourceReport"
392-
) -> List[KafkaConnectLineage]:
393-
"""Extract lineages for this connector using connector registry."""
394-
from datahub.ingestion.source.kafka_connect.connector_registry import (
395-
ConnectorRegistry,
396-
)
397-
398-
return ConnectorRegistry.extract_lineages(self, config, report)
399-
400-
def extract_flow_property_bag(
401-
self, config: "KafkaConnectSourceConfig", report: "KafkaConnectSourceReport"
402-
) -> Optional[Dict[str, str]]:
403-
"""Extract flow property bag for this connector using connector registry."""
404-
from datahub.ingestion.source.kafka_connect.connector_registry import (
405-
ConnectorRegistry,
406-
)
407-
408-
return ConnectorRegistry.extract_flow_property_bag(self, config, report)
409-
410390
def get_topics_from_config(
411391
self, config: "KafkaConnectSourceConfig", report: "KafkaConnectSourceReport"
412392
) -> List[str]:

metadata-ingestion/src/datahub/ingestion/source/kafka_connect/connector_registry.py

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"""
66

77
import logging
8-
from typing import TYPE_CHECKING, Dict, List, Optional
8+
from typing import TYPE_CHECKING, List, Optional
99

1010
from datahub.ingestion.source.kafka_connect.common import (
1111
CLOUD_JDBC_SOURCE_CLASSES,
@@ -213,34 +213,6 @@ def _get_sink_connector(
213213

214214
return None
215215

216-
@staticmethod
217-
def extract_lineages(
218-
manifest: ConnectorManifest,
219-
config: KafkaConnectSourceConfig,
220-
report: KafkaConnectSourceReport,
221-
) -> List[KafkaConnectLineage]:
222-
"""Extract lineages using the appropriate connector."""
223-
connector = ConnectorRegistry.get_connector_for_manifest(
224-
manifest, config, report
225-
)
226-
if connector:
227-
return connector.extract_lineages()
228-
return []
229-
230-
@staticmethod
231-
def extract_flow_property_bag(
232-
manifest: ConnectorManifest,
233-
config: KafkaConnectSourceConfig,
234-
report: KafkaConnectSourceReport,
235-
) -> Optional[Dict[str, str]]:
236-
"""Extract flow property bag using the appropriate connector."""
237-
connector = ConnectorRegistry.get_connector_for_manifest(
238-
manifest, config, report
239-
)
240-
if connector:
241-
return connector.extract_flow_property_bag()
242-
return None
243-
244216
@staticmethod
245217
def get_topics_from_config(
246218
manifest: ConnectorManifest,

metadata-ingestion/src/datahub/ingestion/source/kafka_connect/source_connectors.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,14 +1067,8 @@ def _derive_topics_from_config(self) -> List[str]:
10671067
"""Extract topics directly from connector configuration - most reliable approach."""
10681068
config = self.connector_manifest.config
10691069

1070-
# Use the connector registry for configuration-based topic derivation
1071-
from datahub.ingestion.source.kafka_connect.connector_registry import (
1072-
ConnectorRegistry,
1073-
)
1074-
1075-
config_topics = ConnectorRegistry.get_topics_from_config(
1076-
self.connector_manifest, self.config, self.report
1077-
)
1070+
# Call own get_topics_from_config method directly to avoid creating new instance
1071+
config_topics = self.get_topics_from_config()
10781072

10791073
if config_topics:
10801074
# Apply predictable transforms to get final topic names

0 commit comments

Comments
 (0)