-
Notifications
You must be signed in to change notification settings - Fork 3.3k
add clone back into menu #15240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add clone back into menu #15240
Conversation
Bundle ReportChanges will increase total bundle size by 42.81kB (0.15%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
|
✅ Meticulous spotted visual differences in 4 of 949 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~8 hours of user flows against your PR. Last updated for commit 2e661a8. This comment will update as new commits are pushed. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
chriscollins3456
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good! suggestion on updating the name here to have (copy) in the name by default otherwise we throw errors if they create a term with the same name at the same level
| setStagedName(properties.name); | ||
| form.setFieldValue('name', properties.name); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about doing ${properties.name} (copy) here? for both of these setters
This was missing from v2, but in v1; I dont think it ever made it over:
Before:


After:

Screen.Recording.2025-11-07.at.1.31.47.PM.mov