Skip to content

Conversation

@annadoesdesign
Copy link
Contributor

This was missing from v2, but in v1; I dont think it ever made it over:

Before:
Screenshot 2025-11-07 at 1 33 46 PM
Screenshot 2025-11-07 at 1 33 58 PM

After:
Screenshot 2025-11-07 at 1 33 17 PM

Screen.Recording.2025-11-07.at.1.31.47.PM.mov

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 7, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Bundle Report

Changes will increase total bundle size by 42.81kB (0.15%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.63MB 42.81kB (0.15%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 74.1kB 19.0MB 0.39%
assets/sample-*.png (Deleted) -29.82kB 0 bytes -100.0% 🗑️
assets/theme_v2.config-*.js (Deleted) -1.47kB 0 bytes -100.0% 🗑️

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/EntityDropdown/EntityMenuActions.tsx → Total Size: 3.74kB

  • ./src/app/entityV2/glossaryTerm/GlossaryTermEntity.tsx → Total Size: 5.5kB

  • ./src/app/entityV2/shared/EntityDropdown/CreateGlossaryEntityModal.tsx → Total Size: 8.44kB

  • ./src/app/entityV2/shared/EntityDropdown/EntityDropdown.tsx → Total Size: 14.06kB

  • ./src/app/entityV2/glossaryNode/GlossaryNodeEntity.tsx → Total Size: 4.34kB

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Nov 7, 2025

✅ Meticulous spotted visual differences in 4 of 949 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 2e661a8. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good! suggestion on updating the name here to have (copy) in the name by default otherwise we throw errors if they create a term with the same name at the same level

Comment on lines +67 to +69
setStagedName(properties.name);
form.setFieldValue('name', properties.name);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about doing ${properties.name} (copy) here? for both of these setters

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants