Skip to content

Conversation

@shirshanka
Copy link
Contributor

Summary

Migrate the RFC (Request for Comments) process from the separate datahub-project/rfcs repository back to the main DataHub repository to improve visibility and reduce contributor friction.

This represents a "fresh start" for RFCs - historical RFCs remain accessible in git history and the archived external repository, but will be migrated on an as-needed basis when they become relevant.

Changes

  • Created docs/rfcs/ directory structure with active/ and accepted/ subdirectories
  • Added docs/rfcs/README.md explaining the fresh start and directory structure
  • Added docs/rfcs/template.md RFC submission template
  • Updated docs/rfc.md to reference main repo instead of external datahub-project/rfcs
  • Updated docs-website/sidebars.js to include RFCs in navigation
  • Updated all Slack channel references from #rfc to #contribute-code

Next Steps

After this PR is merged:

  1. Archive the external datahub-project/rfcs repository
  2. Add deprecation notice to the external repo README directing contributors to main repo
  3. Close open PRs in external repo with migration instructions

Test Plan

  • Documentation generates correctly (ran generateDocsDir.ts)
  • Files pass pre-commit hooks (prettier, linting)
  • Sidebar configuration valid
  • All internal links work

🤖 Generated with Claude Code

shirshanka and others added 2 commits November 7, 2025 19:38
Migrate the RFC (Request for Comments) process from the separate
datahub-project/rfcs repository back to the main DataHub repository
to improve visibility and reduce contributor friction.

This represents a "fresh start" for RFCs - historical RFCs remain
accessible in git history and the archived external repository, but
will be migrated on an as-needed basis when they become relevant.

Changes:
- Created docs/rfcs/ directory structure with active/ and accepted/ subdirectories
- Added docs/rfcs/README.md explaining the fresh start and directory structure
- Added docs/rfcs/template.md RFC submission template
- Updated docs/rfc.md to reference main repo instead of external datahub-project/rfcs
- Updated docs-website/sidebars.js to include RFCs in navigation

The external datahub-project/rfcs repository should be archived with a
deprecation notice directing contributors to the main repository.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Update all RFC documentation to reference #contribute-code instead of
#rfc, consolidating contribution discussions into a single channel.

Changes:
- Updated docs/rfc.md (3 references)
- Updated docs/rfcs/README.md (1 reference)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Nov 8, 2025

🔴 Meticulous spotted visual differences in 2 of 1067 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 6978224. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Fix several documentation build issues:
- Comment out missing GraphQL reference docs (queries, mutations, objects, etc.)
- Comment out missing Python SDK reference docs (builder, clients, sdk-v2, models, urns)
- Exclude RFC template.md from doc generation to avoid JSX parsing errors
- Remove markdown links to template.md to avoid broken link errors
- Escape angle brackets in template.md title

These changes fix sidebar validation errors and broken link errors while
maintaining documentation structure. The commented-out sections can be
re-enabled when the referenced documentation is generated.

Note: Pre-existing broken links to graphql and python-sdk docs remain
(not introduced by RFC migration changes).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues and Improvements to docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants