Clean up JSBrowserWindowInstance constructor

frankhale · frankhale · commit 6115653a2244 · 2017-05-31T13:37:06.000-04:00
diff --git a/Electrino/win10/Electrino/JS/JSBrowserWindow.cs b/Electrino/win10/Electrino/JS/JSBrowserWindow.cs
@@ -38,12 +38,11 @@ protected override JavaScriptValue Main(JavaScriptValue callee, bool isConstruct
     class JSBrowserWindowInstance : AbstractJSModule
     {
         private JToken options;
-        // I don't really like putting this here, I think we should probably have a class that contains all our constants
-        private const int defaultWindowWidth = 800, defaultWindowHeight = 600;
         private Dictionary<string, List<Tuple<JavaScriptValue, JavaScriptValue>>> listeners = new Dictionary<string, List<Tuple<JavaScriptValue, JavaScriptValue>>>();
 
         public JSBrowserWindowInstance(JToken options) : base("BrowserWindowInstance")
         {
+            const int defaultWindowWidth = 800, defaultWindowHeight = 600;
             int width = 0, height = 0;
             this.options = options;
 

Original file line number	Diff line number	Diff line change
`@@ -38,12 +38,11 @@ protected override JavaScriptValue Main(JavaScriptValue callee, bool isConstruct`
`38`	`38`	`class JSBrowserWindowInstance : AbstractJSModule`
`39`	`39`	`{`
`40`	`40`	`private JToken options;`
`41`		`- // I don't really like putting this here, I think we should probably have a class that contains all our constants`
`42`		`- private const int defaultWindowWidth = 800, defaultWindowHeight = 600;`
`43`	`41`	`private Dictionary<string, List<Tuple<JavaScriptValue, JavaScriptValue>>> listeners = new Dictionary<string, List<Tuple<JavaScriptValue, JavaScriptValue>>>();`
`44`	`42`
`45`	`43`	`public JSBrowserWindowInstance(JToken options) : base("BrowserWindowInstance")`
`46`	`44`	`{`
	`45`	`+ const int defaultWindowWidth = 800, defaultWindowHeight = 600;`
`47`	`46`	`int width = 0, height = 0;`
`48`	`47`	`this.options = options;`
`49`	`48`