-
Notifications
You must be signed in to change notification settings - Fork 136
Add git submodules for specs #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: add-github-workflow
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor if this approach because the advantages outweigh the disadvantages. If this ever changes, it's not that much work to change it.
@anatoly-scherbakov as a sort of compromise: should we add a 'testing without submodules' paragraph to the README.md? Basically what you said in #182 (comment) about changing the path of the specs.
|
@mielvds sure; this PR, however, doesn't change the behavior of the test system. It only affects existence of submodules and usage of them in CI. We can update the docs in another PR. Making PRs smaller could speed up merging. |
|
It kind of changes the test system, because contributors now need to init submodules instead of cloning them (although they still could). I'm all for small PR's, but I also like them to include documentation about the changes they introduce. It's a balance.
So makefile is covered by #191, but I would add the snippets here because it's not that much work (I can add this). |
After this PR, contributors are not yet required to do so, they might continue cloning specs separately as before. This PR prepares the repo for a submodule-aware workflow. In a follow up PR, I will:
if that makes sense. Let me know what you think. |
|
allright with me! if possible, i'd like to wait for @davidlehn and @BigBlueHat for the final go? |
|
Thanks! I would also prefer the upstream, |
I think my previous PR was trying to change too much and I decided it would be easier to recreate the most important changes in a new one.
This PR:
normalizationwhich is nowrdf-canonis out of scope for now),gitsubmodules #181 Add submodules for JSON-LD API & Framing specificationsgitsubmodules #181 Use spec git submodules in CI