Merge pull request #3345 from dimagi/fixConnectUpgrade

Fixes Connect DB upgrade

Author: shubham1g5

app/src/org/commcare/models/database/connect/ConnectDatabaseUpgrader.java

@@ -641,6 +641,7 @@ private void upgradeSeventeenEighteen(IDatabase db) {
             // We have not been populating this table yet, so just drop and recreate
             SqlStorage.dropTable(db, PersonalIdCredential.STORAGE_KEY);
             addTableForNewModel(db, PersonalIdCredential.STORAGE_KEY, new PersonalIdCredential());
+            db.setTransactionSuccessful();
         } finally {
             db.endTransaction();
         }
@@ -653,7 +654,6 @@ private static void addTableForNewModel(IDatabase db, String storageKey,
             TableBuilder builder = new TableBuilder(storageKey);
             builder.addData(modelToAdd);
             db.execSQL(builder.getTableCreateString());
-
             db.setTransactionSuccessful();
         } finally {
             db.endTransaction();