fixed for loop .. issue replaced with until

Author: pm-dimagi

app/src/org/commcare/connect/ConnectAppUtils.kt

@@ -138,7 +138,7 @@ object ConnectAppUtils {
         val charSet = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789_!.?"
         val secureRandom = SecureRandom()
         val password = StringBuilder(passwordLength)
-        for (i in 0..<passwordLength) {
+        for (i in 0 until passwordLength) {
             password.append(charSet[secureRandom.nextInt(charSet.length)])
         }
 

app/src/org/commcare/connect/ConnectJobHelper.kt

@@ -89,7 +89,7 @@ object ConnectJobHelper {
                         val modules = json.getJSONArray(key)
                         val learningRecords: MutableList<ConnectJobLearningRecord> =
                             ArrayList(modules.length())
-                        for (i in 0..<modules.length()) {
+                        for (i in 0 until modules.length()) {
                             val obj = modules[i] as JSONObject
                             val record = ConnectJobLearningRecord.fromJson(obj, job.jobId)
                             learningRecords.add(record)
@@ -101,7 +101,7 @@ object ConnectJobHelper {
                         val assessments = json.getJSONArray(key)
                         val assessmentRecords: MutableList<ConnectJobAssessmentRecord> =
                             ArrayList(assessments.length())
-                        for (i in 0..<assessments.length()) {
+                        for (i in 0 until assessments.length()) {
                             val obj = assessments[i] as JSONObject
                             val record = ConnectJobAssessmentRecord.fromJson(obj, job.jobId)
                             assessmentRecords.add(record)
@@ -210,7 +210,7 @@ object ConnectJobHelper {
                         key = "deliveries"
                         if (json.has(key)) {
                             val array = json.getJSONArray(key)
-                            for (i in 0..<array.length()) {
+                            for (i in 0 until array.length()) {
                                 val obj = array[i] as JSONObject
                                 deliveries.add(ConnectJobDeliveryRecord.fromJson(obj, job.jobId))
                             }
@@ -225,7 +225,7 @@ object ConnectJobHelper {
                         key = "payments"
                         if (json.has(key)) {
                             val array = json.getJSONArray(key)
-                            for (i in 0..<array.length()) {
+                            for (i in 0 until array.length()) {
                                 val obj = array[i] as JSONObject
                                 payments.add(ConnectJobPaymentRecord.fromJson(obj, job.jobId))
                             }