catch error

[juchanhwang]

if i modify this code(in then() method)

super.then(
  value => onSettled("resolved", value, onFulfilled),
  reason => onSettled("rejected", reason, onRejected)
);

to

super
  .then( value => onSettled("resolved", value, onFulfilled))
  .catch( reason => onSettled("rejected", reason, onRejected))

my code occures this error
abortable-promise.ts:131 Uncaught (in promise) RangeError: Maximum call stack size exceeded

[dondevi]

You can't do that because they are different.

• Rule 1: It creates a new Promise everytime you do .then, .catch (and .abort)
• Rule 2: Internally super.catch(onRejected) will be this.then(undefined, onRejected)

Let’s say:

const promise = new AbortablePromise();
promise.then();  // Without this in your modify, it won't throw errors

- Case 1: super.then(onFulfilled, onRejected)

1. promise.then
2. new AbortablePromise
3. super.then
4. (End)

- Case 2: super.then(onFulfilled).catch(onRejected)

1. promise.then
2. new AbortablePromise
3. super.then
4. super.catch
5. AbortablePromise.then (See Rule 2)
6. new AbortablePromise
7. super.then
8. (Endless loop...)