Skip to content

Commit 49375b5

Browse files
KevinRansombrettfo
authored andcommitted
CP: Use Framework valuetuple rather than netstandard1.0 one (#5872)
* Use Framework valuetuple rather than netstandard1.0 one (#5867) * remove references from template
1 parent 2bf3a16 commit 49375b5

File tree

8 files changed

+9
-33
lines changed

8 files changed

+9
-33
lines changed

build.cmd

+2-2
Original file line numberDiff line numberDiff line change
@@ -611,8 +611,8 @@ if exist "%ProgramFiles%\Microsoft Visual Studio 12.0\common7\ide\devenv.exe" se
611611
:vsversionset
612612
if "%VisualStudioVersion%" == "" echo Error: Could not find an installation of Visual Studio && goto :failure
613613

614-
if exist "%VS160COMNTOOLS%\..\..\MSBuild\15.0\Bin\MSBuild.exe" (
615-
set _msbuildexe="%VS160COMNTOOLS%\..\..\MSBuild\15.0\Bin\MSBuild.exe"
614+
if exist "%VS160COMNTOOLS%\..\..\MSBuild\Current\Bin\MSBuild.exe" (
615+
set _msbuildexe="%VS160COMNTOOLS%\..\..\MSBuild\Current\Bin\MSBuild.exe"
616616
goto :havemsbuild
617617
)
618618
if exist "%VS150COMNTOOLS%\..\..\MSBuild\15.0\Bin\MSBuild.exe" (

vsintegration/ProjectTemplates/ConsoleProject/Template/ConsoleApplication.fsproj

-8
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,6 @@
4242
<Reference Include="System"/>
4343
<Reference Include="System.Core"/>
4444
<Reference Include="System.Numerics"/>
45-
<Reference Include="FSharp.Core">
46-
<HintPath>..\packages\FSharp.Core.4.5.2\lib\net45\FSharp.Core.dll</HintPath>
47-
<Private>True</Private>
48-
</Reference>
49-
<Reference Include="System.ValueTuple">
50-
<HintPath>..\packages\System.ValueTuple.4.4.0\lib\netstandard1.0\System.ValueTuple.dll</HintPath>
51-
<Private>True</Private>
52-
</Reference>
5345
</ItemGroup>
5446
<ItemGroup>
5547
<Compile Include="AssemblyInfo.fs" />

vsintegration/ProjectTemplates/ConsoleProject/Template/ConsoleApplication.vstemplate

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
</WizardExtension>
2727
<WizardData>
2828
<packages repository="extension" repositoryId="VisualFSharpTemplates">
29-
<package id="System.ValueTuple" version="4.4.0" targetFramework="net40" skipAssemblyReferences="true" />
30-
<package id="FSharp.Core" version="4.5.2" targetFramework="net40" skipAssemblyReferences="true" />
29+
<package id="System.ValueTuple" version="4.4.0" />
30+
<package id="FSharp.Core" version="4.5.2" />
3131
</packages>
3232
</WizardData>
3333
</VSTemplate>

vsintegration/ProjectTemplates/LibraryProject/Template/Library.fsproj

-8
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,6 @@
3838
<Reference Include="System"/>
3939
<Reference Include="System.Core"/>
4040
<Reference Include="System.Numerics"/>
41-
<Reference Include="FSharp.Core">
42-
<HintPath>..\packages\FSharp.Core.4.5.2\lib\net45\FSharp.Core.dll</HintPath>
43-
<Private>True</Private>
44-
</Reference>
45-
<Reference Include="System.ValueTuple">
46-
<HintPath>..\packages\System.ValueTuple.4.4.0\lib\netstandard1.0\System.ValueTuple.dll</HintPath>
47-
<Private>True</Private>
48-
</Reference>
4941
</ItemGroup>
5042
<ItemGroup>
5143
<Compile Include="AssemblyInfo.fs" />

vsintegration/ProjectTemplates/LibraryProject/Template/Library.vstemplate

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
</WizardExtension>
2727
<WizardData>
2828
<packages repository="extension" repositoryId="VisualFSharpTemplates">
29-
<package id="System.ValueTuple" version="4.4.0" targetFramework="net40" skipAssemblyReferences="true" />
30-
<package id="FSharp.Core" version="4.5.2" targetFramework="net40" skipAssemblyReferences="true" />
29+
<package id="System.ValueTuple" version="4.4.0" />
30+
<package id="FSharp.Core" version="4.5.2" />
3131
</packages>
3232
</WizardData>
3333
</VSTemplate>

vsintegration/ProjectTemplates/TutorialProject/Template/Tutorial.fsproj

-8
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,6 @@
4545
<Reference Include="System.Numerics"/>
4646
<Reference Include="System.Drawing"/>
4747
<Reference Include="System.Windows.Forms"/>
48-
<Reference Include="FSharp.Core">
49-
<HintPath>..\packages\FSharp.Core.4.5.2\lib\net45\FSharp.Core.dll</HintPath>
50-
<Private>True</Private>
51-
</Reference>
52-
<Reference Include="System.ValueTuple">
53-
<HintPath>..\packages\System.ValueTuple.4.4.0\lib\netstandard1.0\System.ValueTuple.dll</HintPath>
54-
<Private>True</Private>
55-
</Reference>
5648
</ItemGroup>
5749
<ItemGroup>
5850
<Compile Include="Tutorial.fsx" />

vsintegration/ProjectTemplates/TutorialProject/Template/Tutorial.vstemplate

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
</WizardExtension>
2525
<WizardData>
2626
<packages repository="extension" repositoryId="VisualFSharpTemplates">
27-
<package id="System.ValueTuple" version="4.4.0" targetFramework="net40" skipAssemblyReferences="true" />
28-
<package id="FSharp.Core" version="4.5.2" targetFramework="net40" skipAssemblyReferences="true" />
27+
<package id="System.ValueTuple" version="4.4.0" />
28+
<package id="FSharp.Core" version="4.5.2" />
2929
</packages>
3030
</WizardData>
3131
</VSTemplate>

vsintegration/Vsix/VisualFSharpTemplates/VisualFSharpTemplates.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<AssemblyName>VisualFSharpTemplate</AssemblyName>
77
<OutputType>Library</OutputType>
88
<ExtensionInstallationFolder>Microsoft\FSharpTemplates</ExtensionInstallationFolder>
9-
<DeployExtension>false</DeployExtension>
9+
<DeployExtension>true</DeployExtension>
1010
</PropertyGroup>
1111

1212
<ItemGroup>

0 commit comments

Comments
 (0)