more tests

Author: edgarfgp

tests/FSharp.Compiler.ComponentTests/Conformance/BasicGrammarElements/UseBindings/UseBinding01.fs

@@ -0,0 +1,7 @@
+// #DeclarationElements #LetBindings 
+//<Expects status="success"></Expects>
+open System
+
+let answer =
+    use x:IDisposable = new System.IO.MemoryStream()
+    42

tests/FSharp.Compiler.ComponentTests/Conformance/BasicGrammarElements/UseBindings/UseBinding02.fs

@@ -0,0 +1,26 @@
+open System
+
+type private Disposable() =
+    [<DefaultValue>] static val mutable private disposedTimes: int
+    [<DefaultValue>] static val mutable private constructedTimes: int
+
+    do Disposable.constructedTimes <- Disposable.constructedTimes + 1
+
+    static member DisposeCallCount() = Disposable.disposedTimes
+    static member ConstructorCallCount() = Disposable.constructedTimes
+
+    interface System.IDisposable with
+        member _.Dispose() =
+            Disposable.disposedTimes <- Disposable.disposedTimes + 1
+
+let _scope =
+    use x: IDisposable = new Disposable()
+    ()
+
+let disposeCalls = Disposable.DisposeCallCount()
+if disposeCalls <> 1 then
+    failwith "was not disposed or disposed too many times"
+
+let ctorCalls = Disposable.ConstructorCallCount()
+if ctorCalls <> 1 then
+    failwithf "unexpected constructor call count: %i" ctorCalls

tests/FSharp.Compiler.ComponentTests/Conformance/BasicGrammarElements/UseBindings/UseBindingDiscard03.fs

@@ -0,0 +1,26 @@
+open System
+
+type private Disposable() =
+    [<DefaultValue>] static val mutable private disposedTimes: int
+    [<DefaultValue>] static val mutable private constructedTimes: int
+
+    do Disposable.constructedTimes <- Disposable.constructedTimes + 1
+
+    static member DisposeCallCount() = Disposable.disposedTimes
+    static member ConstructorCallCount() = Disposable.constructedTimes
+
+    interface System.IDisposable with
+        member _.Dispose() =
+            Disposable.disposedTimes <- Disposable.disposedTimes + 1
+
+let _scope =
+    use _:IDisposable = new Disposable()
+    ()
+
+let disposeCalls = Disposable.DisposeCallCount()
+if disposeCalls <> 1 then
+    failwith "was not disposed or disposed too many times"
+
+let ctorCalls = Disposable.ConstructorCallCount()
+if ctorCalls <> 1 then
+    failwithf "unexpected constructor call count: %i" ctorCalls

tests/FSharp.Compiler.ComponentTests/Conformance/BasicGrammarElements/UseBindings/UseBindings.fs

@@ -33,4 +33,25 @@ module UseBindings =
         |> asExe
         |> withLangVersion60
         |> compileAndRun
-        |> shouldSucceed
+        |> shouldSucceed
+        
+    [<Theory; Directory(__SOURCE_DIRECTORY__, Includes=[|"UseBindingDiscard03.fs"|])>]
+    let ``UseBindings - UseBindingDiscard03_fs - Current LangVersion`` compilation =
+        compilation
+        |> asExe
+        |> compileAndRun
+        |> shouldSucceed
+        
+    [<Theory; Directory(__SOURCE_DIRECTORY__, Includes=[|"UseBinding01.fs"|])>]
+    let ``UseBindings - UseBinding01_fs - Current LangVersion`` compilation =
+        compilation
+        |> asFsx
+        |> compile
+        |> shouldSucceed
+
+    [<Theory; Directory(__SOURCE_DIRECTORY__, Includes=[|"UseBinding02.fs"|])>]
+    let ``UseBindings - UseBinding02_fs - Current LangVersion`` compilation =
+        compilation
+        |> asFsx
+        |> compile
+        |> shouldSucceed

tests/FSharp.Compiler.ComponentTests/Language/ComputationExpressionTests.fs

@@ -22,21 +22,6 @@ let x = lb {1; 2;}
         |> compile
         |> shouldSucceed
         |> ignore
-        
-    [<Fact>]
-    let ``Allow let! and use! binding with type annotation without parentheses.``() =
-        FSharp """
-module ComputationExpressionTests
-let f =
-    async {
-        let! (a: int) = async { return 1 }
-        let! b: int = async { return 1 } 
-        return a
-    }
-        """
-        |> typecheck
-        |> shouldSucceed
-        |> ignore
 
     [<Fact>]
     let ``A CE explicitly using Zero fails without a defined Zero``() =