Auto-complete triggering keyword completions too often

[dsyme]

If we type this:

type Option(v)

then void appears as a completion - when we hit : this text is inserted

[smoothdeveloper]

Beside avoiding : to complete, what would be the ideal expected behaviour, beyond the bug fix?

Maybe it should only list things that are valid as binding pattern in this particular context ? maybe propose some of the attributes that are valid to put on method parameters (with the whole [< >] prefix/suffix baked in the intelisense list).

[dsyme]

Labelling this as a regression - it's been like this a while but not forever, and should never have been allowed to regress

[dsyme]

Beside avoiding : to complete, what would be the ideal expected behaviour, beyond the bug fix?

I don't really know, I haven't looked at the FSharp.Editor completion code in quite a long time and it's a bit unclear what all the options are.

My first thought on a minimal fix is that this

fsharp/vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs

Line 54 in b3d46d4

rules = CompletionItemRules.Default,

should be noCommitOnSpaceRules? Are you familiar with this code?

It seems this only affects keywords, and may be exactly what's needed? It seems to fix the problem? I've only ever noticed this problem with keywords.

What I don't understand is why this

fsharp/vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs

Line 158 in b3d46d4

rules = getRules intellisenseOptions.ShowAfterCharIsTyped,

depends on the intellisense options.

@cartermp Do you have any insight here? thanks

[dsyme]

Fixed by #12318, manual testing so far

[dsyme]

Duplicate of #11145